fix: clean up instance remove lifecycle hooks - #9085
Open
slash-init wants to merge 2 commits into
Open
Conversation
slash-init
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9072
Changes:
Replaced the instance-specific lifecycle hook named
removethat was used for clearing thefocusandblurevent listeners with the signal from the existingAbortController.This stops the function
p5.lifecycleHooks.removefrom accumulating hooks when p5 instances are removed. I've also added a regression test to ensure that the hooks are cleaned up after the instances have been removed.Screenshots of the change:
Not applicable.
PR Checklist
npm run lintpasses