GSOC 26: custom vertex attributes in multi-material buildGeometry - #9077
Open
Nixxx19 wants to merge 2 commits into
Open
GSOC 26: custom vertex attributes in multi-material buildGeometry#9077Nixxx19 wants to merge 2 commits into
Nixxx19 wants to merge 2 commits into
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: cf3cab7 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #9063.
before, buildGeometry() only exposed the per-material parts when there were multiple materials and no custom per-vertex attributes. if you used vertexProperty(), the split was skipped and the geometry stayed whole, so you lost the material parts.
this makes custom vertex attributes work with the multi-material split:
added a test that builds a two material geometry with a custom attribute and checks each part carries its own values aligned to its vertices. the change is in the shared builder so it works in both webgl and webgpu.