Skip to content

fix(ffi): pass transparent=false to all surface_create_* calls #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pepc84 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ffi): pass transparent=false to all surface_create_* calls #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 24 additions & 4 deletions crates/processing_ffi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub extern "C" fn processing_surface_create(
scale_factor: f32,
) -> u64 {
error::clear_error();
error::check(|| surface_create_windows(window_handle, width, height, scale_factor))
error::check(|| surface_create_windows(window_handle, width, height, scale_factor, false))
.map(|e| e.to_bits())
.unwrap_or(0)
}
Expand All @@ -87,7 +87,7 @@ pub extern "C" fn processing_surface_create_wayland(
) -> u64 {
error::clear_error();
error::check(|| {
surface_create_wayland(window_handle, display_handle, width, height, scale_factor)
surface_create_wayland(window_handle, display_handle, width, height, scale_factor, false)
})
.map(|e| e.to_bits())
.unwrap_or(0)
Expand All @@ -110,7 +110,7 @@ pub extern "C" fn processing_surface_create_x11(
scale_factor: f32,
) -> u64 {
error::clear_error();
error::check(|| surface_create_x11(window_handle, display_handle, width, height, scale_factor))
error::check(|| surface_create_x11(window_handle, display_handle, width, height, scale_factor, false))
.map(|e| e.to_bits())
.unwrap_or(0)
}
Expand All @@ -133,7 +133,7 @@ pub extern "C" fn processing_surface_create(
) -> u64 {
error::clear_error();
error::check(|| {
surface_create_linux(window_handle, display_handle, width, height, scale_factor)
surface_create_linux(window_handle, display_handle, width, height, scale_factor, false)
})
.map(|e| e.to_bits())
.unwrap_or(0)
Expand Down Expand Up @@ -4436,3 +4436,23 @@ fn key_code_to_u32(kc: KeyCode) -> u32 {
_ => 0,
}
}

/// Tick the Bevy app one frame and poll GLFW events.
/// Call this once per frame from your external event loop, before begin_draw.
/// Returns true if the app should continue running, false if it should exit.
///
/// SAFETY:
/// - processing_init has been called.
/// - This is called from the same thread as init.
#[unsafe(no_mangle)]
pub extern "C" fn processing_poll_events() -> bool {
error::clear_error();
let result = processing_core::app_mut(|app| {
app.update();
Ok(())
});
match result {
Ok(_) => true,
Err(_) => false,
}
}
Loading