Repository navigation
test: remove unused toolbar 4.x selectors - #282
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppPage.toolbarandAppPage.exitPreviewuse toolbar 4.x selectors that toolbar v5 (prismicio/prismic-toolbar#149) removes. No test uses them, so this removes them.🤖 Generated with Claude Code
Note
Low Risk
Test-only deletion of unused helpers; no production or active E2E paths affected.
Overview
Removes dead Playwright AppPage helpers that targeted Prismic toolbar 4.x DOM (
#prismic-toolbar-v2 .PreviewMenu) and the unusedexitPreview()flow (close icon + assert toolbar gone). Those selectors break with toolbar v5, and nothing in the suite called them.Also drops the unused
expectimport from@playwright/test.toolbarScript,toolbarIframe, preview navigation, and script param helpers are unchanged.Reviewed by Cursor Bugbot for commit e583bd6. Bugbot is set up for automated code reviews on this repo. Configure here.