Skip to content

add data-component attributes for Avatar, AvatarStack, Banner, & BaseStyles#7734

Merged
llastflowers merged 17 commits intomainfrom
llastflowers/6497/AvatarStack
Apr 22, 2026
Merged

add data-component attributes for Avatar, AvatarStack, Banner, & BaseStyles#7734
llastflowers merged 17 commits intomainfrom
llastflowers/6497/AvatarStack

Conversation

@llastflowers
Copy link
Copy Markdown
Contributor

@llastflowers llastflowers commented Apr 7, 2026 •
edited
Loading

Relates to https://github.com/github/primer/issues/6497

Changelog

New

Add data-component attributes and associated for Avatar, AvatarStack, Banner, & BaseStyles

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 7, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: ea37cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@llastflowers llastflowers changed the title Add data-component for AvatarStack feat(AvatarStack): add data-component attributes for better accessibility Apr 7, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 7, 2026 22:25 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 7, 2026 22:55 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 7, 2026 23:08 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 7, 2026 23:19 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 7, 2026 23:29 Inactive
francinelucca
francinelucca reviewed Apr 8, 2026
View reviewed changes
Comment thread packages/react/src/AvatarStack/AvatarStack.test.tsx
Comment on lines +44 to +45
const root = container.querySelector('[data-component="AvatarStack"]')
expect(root).toHaveAttribute('data-align-right', '')
Copy link
Copy Markdown
Member

@francinelucca francinelucca Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already being useful! 😛

@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 9, 2026 19:11 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 9, 2026 19:29 Inactive
@llastflowers llastflowers changed the title feat(AvatarStack): add data-component attributes for better accessibility add data-component attributes for Avatar, AvatarStack, Banner, & BaseStyles Apr 9, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 9, 2026 19:40 Inactive
@llastflowers llastflowers marked this pull request as ready for review April 10, 2026 16:17
francinelucca
francinelucca requested changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after #7734 (comment) we're good to go here 👍🏽

@primer primer deleted a comment from primer-integration Bot Apr 10, 2026
@github-actions github-actions Bot requested a deployment to storybook-preview-7734 April 10, 2026 22:35 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 10, 2026 22:46 Inactive
@llastflowers llastflowers added the Canary Release Apply this label when you want CI to create a canary release of the current PR label Apr 10, 2026
francinelucca
francinelucca approved these changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@llastflowers
Add data-component attributes for several components
0d4323c 
Add data-component attributes for Avatar, AvatarStack, Banner, and BaseStyles.
@github-actions github-actions Bot temporarily deployed to storybook-preview-7734 April 17, 2026 18:26 Inactive
@llastflowers llastflowers added integration-tests: skipped manually Changes in this PR do not require an integration test Canary Release Apply this label when you want CI to create a canary release of the current PR and removed integration-tests: skipped manually Changes in this PR do not require an integration test Canary Release Apply this label when you want CI to create a canary release of the current PR labels Apr 18, 2026
@github-actions github-actions Bot requested a deployment to storybook-preview-7734 April 22, 2026 18:09 Abandoned
@primer-integration
Copy link
Copy Markdown

primer-integration Bot commented Apr 22, 2026

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19142

@primer-integration
Copy link
Copy Markdown

primer-integration Bot commented Apr 22, 2026

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@llastflowers llastflowers added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit 421ebf0 Apr 22, 2026
53 checks passed
@llastflowers llastflowers deleted the llastflowers/6497/AvatarStack branch April 22, 2026 18:53
@primer primer Bot mentioned this pull request Apr 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@francinelucca francinelucca francinelucca approved these changes

@liuliu-dev liuliu-dev Awaiting requested review from liuliu-dev liuliu-dev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llastflowers @francinelucca