Check ulimit -n before starting up#167
Open
drdrsh wants to merge 2 commits intopostgresml:mainfrom
Open
Conversation
levkk
reviewed
Sep 16, 2022
| match Command::new("ulimit").arg("-n").output().await { | ||
| Ok(output) => { | ||
| let result = String::from_utf8_lossy(&output.stdout); | ||
| match result.trim_end().parse::<i64>() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One common gotcha when using Pgbouncer is setting the limit of open file descriptions (
ulimit -n) too low. This problem will manifest when the number of open connections reaches that limit, the proxy will stop accepting connections after that point, needless to say this is the worst time for this problem to manifest because the system is already under load.In this PR, we have Pgcat check the limit at startup and exit if it is set too low.