Skip to content

Minor refactor to decouple config from the rest of the app#135

Open
drdrsh wants to merge 1 commit intopostgresml:mainfrom
drdrsh:mostafa_decouple-config
Open

Minor refactor to decouple config from the rest of the app#135
drdrsh wants to merge 1 commit intopostgresml:mainfrom
drdrsh:mostafa_decouple-config

Conversation

@drdrsh
Copy link
Copy Markdown
Collaborator

@drdrsh drdrsh commented Aug 20, 2022

Today, if we want to import config crate, we have to import the entire universe because reload_config references ConnectionPool and importing ConnectionPool cascades into importing the entire app.

This refactor removes reload_config from config.rs and places it in main.rs

This will allow us to import the config crate into external binaries that want to serialize/deserialize configs without having to import the entire app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant