BREAKING: Make same-file duplicate skipping the default - #602
Merged
Conversation
Collaborator
|
@Nic-Polumeyv You'll want to rebase this now that #605 is merged. Also, are you up to modifying this to remove the content-hash-matching logic outright (keeping |
Nic-Polumeyv
force-pushed
the
skipduplicates-same-file
branch
from
August 11, 2026 19:25
9d48439 to
fb2cf1e
Compare
RyanZim
approved these changes
Aug 12, 2026
RyanZim
reviewed
Aug 12, 2026
There was a problem hiding this comment.
Pull request overview
Changes duplicate skipping to deduplicate by resolved file path rather than identical content, preventing path-dependent semantics from being dropped.
Changes:
- Removes content-hash deduplication.
- Adds coverage for identical content at different paths.
- Updates expected output and option documentation.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
index.js |
Removes hash-tracking state. |
lib/parse-styles.js |
Removes content-based duplicate checks. |
README.md |
Updates skipDuplicates documentation. |
test/import.js |
Registers the new regression fixture. |
test/fixtures/same-file-dedup.css |
Imports distinct and repeated paths. |
test/fixtures/same-file-dedup.expected.css |
Verifies path-based deduplication. |
test/fixtures/imports/same-file-dedup/a/shared.css |
Adds first identical source file. |
test/fixtures/imports/same-file-dedup/b/shared.css |
Adds second identical source file. |
test/fixtures/no-duplicate.expected.css |
Updates expectations without content deduplication. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RyanZim
approved these changes
Aug 12, 2026
Collaborator
|
Thanks a lot @Nic-Polumeyv! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked per the discussion in #601: content-hash matching is removed and
skipDuplicatesstays a boolean.no-duplicate.expected.csshad the content behavior baked into its default expectations and is regenerated.Fixes #601