Conversation
Collaborator
|
The linked issue had 2 options: A) Allow expressions or B) Catch in validation. But there might be a 3rd option C) which is fiddling with the grammar so the parsing is correct but the contents illegal. It might be worth having Claude explore the option for a bit before we commit to option B. |
Collaborator
Author
|
that might be possible for the exact issue described there, but when a new parsing issue happens that result in the same we are back at square one. This PR address a real deficiency in how we treat the result of validation which is currently erroneous |
teunbrand
reviewed
Apr 28, 2026
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
I have one concern about a false positive case, if I'm reading the code right
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #256