Fix/increment headers sequential suffix - #19
Closed
gomcodoctor wants to merge 8 commits into
Closed
gomcodoctor wants to merge 8 commits into
gomcodoctor wants to merge 8 commits into
Conversation
customized reader file
return type added
auto_detect_line_endings removed
"portphp/portphp": "dev-master"
trim white space in header added
array_count_values() groups every occurrence of a repeated header together in the output, based on that header's first-appearance order in the input - not the position it actually appeared at. For headers like ['a', 'b', 'a', 'c'] this produces ['a', 'a1', 'b', 'c'], which no longer lines up column-for-column with the CSV row's actual values at those same indexes. Walk $headers in original order instead, incrementing a per-header counter as each duplicate is encountered, so the incremented headers array stays positionally aligned with the row data: ['a', 'b', 'a1', 'c'].
Author
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.