refactor: use named functions for all default components - #336
Merged
Conversation
Anonymous arrow components show up poorly in React DevTools and get weaker React Compiler coverage. Promote every default block, mark, list, and unknown renderer to a named function declaration. Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
🦋 Changeset detectedLatest commit: b0a3113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Only export components that were already part of the public module surface; the block/mark/list helpers stay module-private. Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
stipsan
marked this pull request as ready for review
July 23, 2026 15:35
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every default Portable Text component is now a named function declaration instead of an anonymous/inline arrow.
Why
DefaultH1,DefaultEm, …) instead of anonymous componentsChanges
defaults.tsx— block styles + hard break (DefaultNormal,DefaultH1–DefaultH6,DefaultBlockquote,DefaultHardBreak)marks.tsx— decorators + link (DefaultEm,DefaultStrong,DefaultCode,DefaultUnderline,DefaultStrikeThrough,DefaultLink)list.tsx— lists + list item (DefaultNumberList,DefaultBulletList,DefaultListItem)unknown.tsx— unknown fallbacks converted from const arrows to named functionsNewly introduced helpers stay module-private; only previously exported symbols (
DefaultHardBreak,DefaultListItem, unknown fallbacks, and thedefault*maps) remain exported.No behavior or API changes.