TODO E18: broaden to both roles of the reference peer - #115
Closed
lann wants to merge 1 commit into
Closed
Conversation
Main's post-merge conformance run hit the race in the other direction: wasmtime-x-reference / channel-close-flush failed with 'answerer: channel closed before open', raised by the reference answerer itself (conformance/adapters/reference/src/main.rs). Rewrite E18 to cover both roles: reference-offerer runs lose pre-close payloads, and reference-answerer runs see the channel close before it opens — the common factor is the libwebrtc reference peer, not specifically its offerer close path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Superseded by #116, which carries the completed E18 diagnosis (three receiver-side bugs) plus fixes for two of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's post-#114 conformance run failed on
wasmtime-x-reference / channel-close-flushwithanswerer: channel closed before open— raised by the reference answerer (conformance/adapters/reference/src/main.rs:352), i.e. the E18 race in the opposite direction from the two shapes documented so far (reference-offerer pre-close payload loss). This updates E18 to cover both roles: the common factor across every observed failure is the libwebrtc reference peer, whichever side it's on. The failed job has been re-run (it passes on retry, as usual for this race).