Conversation
The rust/+js/ restructure (182f911) and later growth left the docs contradicting the tree; every claim below is corrected to what the referenced files actually do. - Five dead relative links: the js/componentize README's guest-crate, demo, and toolchain-workflow links (all still resolving inside js/), the wpt README's workflow link, and the componentize-demo README's library link. - The root README described the two componentize checks' requirements backwards: wpt::test componentizes its runner from the tree (there is no published runner component) and downloads the digest-verified toolchain, and componentize::test uses that same downloaded toolchain (nobody here builds the CLI) — per component.sh and the library's Toolchain section. - The js/componentize consumer instructions prescribed a two-interface world, which fails at componentize time against the shim's static imports; the world requirement now points at the webcrypto.js header (the authoritative registry) and the demo's complete world. - The wpt README's vendored table gains the wrapKey_unwrapKey row (landed 0c39433). - `just ci` runs the core CI jobs' checks, not "everything CI runs" / "mirrors CI exactly": the engine-leg jobs (Firefox, the macOS WebKit pair) and the conformance-aggregate job run only in CI (README, AGENTS.md). The hpke experiment's compose comment names justfile.shared.just, where _compose lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287.
Every bullet of the issue, corrected to what the referenced files actually do (each claim re-verified against the tree at HEAD before editing):
js/componentize/README.md's guest-crate link (../polymorph-webcrypto-guest→../../rust/guest; the Rename to polymorph-components/polymorph-webcrypto #330 rename had churned the link text without fixing the path prefix), its demo link (→../../examples/componentize-demo) and toolchain-workflow link (→../../.github/…),js/componentize/wpt/README.md's workflow link (→../../../.github/…), andexamples/componentize-demo/README.md's library link (../../webcrypto-componentize→../../js/componentize). Verified with a relative-link check over every tracked*.md: all filesystem links now resolve (the root README's../../releasesis GitHub-web-relative by design, from releases: caret-honest 0.1.0 regime; polymorph-test + deltic pins to v0.1.0 #383).wpt::testcomponentizes its runner from the tree — there is no published runner component — and downloads the digest-verified toolchain (component.sh's own header);componentize::testuses that same downloaded toolchain rather than "needing the componentize-js CLI" (nobody here builds it — the library README's Toolchain section).webcrypto.jsheader as the authoritative registry (per the docs-state-invariants rule, no second enumerated copy to drift) and at componentize-demo's complete, compilingwit/world.wit.wrapKey_unwrapKeyrow (landed 0c39433), placed in the table where groups.js registers the group, described as component.sh builds it (wrapped callable + vectors file).just ciruns the core CI jobs' checks, not "everything CI runs" / "mirrors CI exactly" — the dedicated engine-leg jobs (the Firefox conformance leg, the macOS WebKit conformance and parity legs) and the cross-target conformance-aggregate job run only in CI (README + AGENTS.md). The hpke experiment's compose comment now namesjustfile.shared.just, where_composelives.Docs-only (plus one justfile comment): the root and hpke justfiles still parse; no gate's inputs change.