conformance: consume deltic from JSR; retire the release-asset fetch - #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the ecosystem ruling in polymorph-iroh#45: the deltic conformance leg moves from raw.githubusercontent URLs + the sha-pinned release-asset fetch to the JSR prereleases deltic publishes per green commit (
0.1.0-pre.g<shorthash>, same hash as the GitHub release). Pin bump rides along:pre-83fff30→ga67ee83(~75 upstream commits; the leg's deltic surface —runSuite,Translator.translate— is API-stable across it).What this buys
fetch-translator.ts(TAG + per-asset sha256 manifest +assertPinConsistency) retires. The deltic-deno legs' translator is@deltic/translator's packaged asset through the module graph — permission-free, sorun-deltic/run-deltic-delegateddrop the release-asset net grants;--translatorsurvives as an optional dev override._deltic-browser-build): the embedder bundle frombrowser-bundle-entry.ts(upstreamtools/release-bundle/entry.ts's exact surface) viadeno bundle --frozen --platform browser, and the translator wasm copied out of the lock-pinned module cache. Serve path goes version-free (target/deltic-browser/; the lock owns versioning, not a path segment). The upstream worker protocol ({bundleUrl, translatorUrl, …}) and the pinned@polymorph/component-test-jsare untouched.deno.json+deno.lock(--frozen), with_deltic-pin-check(a dependency of every deltic recipe) asserting onejsr:@deltic/*version repo-wide — the successor toassertPinConsistency.minimumDependencyAgeexemptsjsr:@deltic/*per deltic's consumption README; everything else keeps Deno's default 24-hour supply-chain gate.Discovered en route: Deno stores remote modules as body + a
// denoCacheMetadata={…}trailer; copying a cached wasm asset wholesale yields a module that failsWebAssembly.compilein the page (the Deno legs never see this — ESM wasm imports read through the cache API).extract-translator-wasm.pytruncates to the graph-reported size and asserts wasm magic + trailer shape.Not changed: worker protocol,
@polymorph/component-test-jspin, Rust (incl. tls-virt pollables), jco history, matrix baseline.Gates (all green):
CONFORMANCE_BROWSER=1 just conformance— deltic-deno 5 pass/2 n/a, deltic-deno-delegated 6 pass/1 n/a, deltic-browser + deltic-browser-delegated green, aggregate 7 targets/42 results/0 failing,matrix-checkempty diff;deno task check; leftover-reference grep clean.