Adopt the gha module: one gha:: recipe per CI job - #37
Merged
Conversation
The websocket/webcrypto arrangement: CI job bodies live in .github/justfile (the gha module), each workflow job runs exactly one `just gha::<job>` recipe with per-recipe log groups and failure annotations, and `just ci` is exactly CI. The workflows carry no logic beyond environment setup. - ci.yml's four jobs each collapse to one gha:: step (rust-checks, smoke, conformance-checks, interop). - timing-lab-scheduled moves into the gha module (workflow-only plumbing, the webcrypto placement); timing-lab.yml follows. - `default` lists recipes, so bare `just` no longer runs `check` -- the family convention. - AGENTS.md's checks table gains the `just ci` row.
# Conflicts: # AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The websocket/webcrypto arrangement, adopted here: CI job bodies live in
.github/justfile(theghamodule), each workflow job runs exactly onejust gha::<job>recipe with per-recipe log groups and failure annotations, andjust ciis exactly CI. The workflows carry no logic beyond environment setup.gha::step (rust-checks,smoke,conformance-checks,interop); every previousrun: just …line survives as a_stepinside the corresponding job recipe, same order.timing-lab-scheduledmoves into the gha module (workflow-only plumbing, the webcrypto placement); timing-lab.yml invokesjust gha::timing-lab-scheduled. The lab stays schedule-only and outsideci.defaultlists recipes, so barejustno longer runscheck— the family convention.just cirow.Verified: every
gha::_steptarget dry-run-resolves; the_stepwrapper exercised in local passthrough, GHA log-group, and failure-annotation modes; workflows parse;just fmt-checkpasses. The substantive gate is this PR's CI, which runs exactly the recipes it always ran, now through the gha module.