retire the npm-git consumption path: the root facade and the setup action's js-locks - #98
Merged
Conversation
The JS runner core's consumers all moved to jsr:@polymorph/test, so the two pieces that existed for npm-git consumption retire: - The root package.json is no longer a package: no name, version, exports, or files — it keeps only the Node ESM type field (Node loads js/viewer/context.js as ESM through it) and says where the consumable surface lives (js/deno.json, the one export map). - actions/setup drops the js-locks input and the --js-lock legs of its pins gate: the cargo rev is the only pin the action holds; the JS side is version-pinned from JSR and gated by each consumer's own runner-js pin check. actions/README's consumer recipe follows. The pins CLI keeps its --js-lock/--package-json flags (released tool surface; unused is harmless). Gates: just check, verify-imports, verify-viewer, publish dry-run — green; the actions-setup-smoke CI job exercises the reduced action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the JSR consumption migration (webcrypto#385, tls#46, websocket#55, webrtc#162): nothing consumes the npm-git path anymore.
package.jsonis no longer a package — it keeps onlytype: module(Node loadsjs/viewer/context.jsas ESM through it) and a pointer to the real manifest (js/deno.json). The keep-two-export-maps-in-sync burden is gone.actions/setupdrops thejs-locksinput and its--js-lockpins-gate legs: the action holds the cargo rev only; the JS side is JSR-version-pinned, gated by each consumer'srunner-jspin check.actions/READMEconsumer recipe updated. (No consumer passes the input anymore; the pins CLI keeps its flags — released surface, harmless.)Gates:
just check,verify-imports,verify-viewer, publish dry-run green;actions-setup-smokeexercises the reduced action in CI.