browser-driver: layout-agnostic self-mount; 0.1.1 - #97
Merged
Conversation
The harness server mounted the directory two levels above browser-driver.mjs and served /js/viewer/* — the retired npm facade's layout, where the module sat at <package>/js/. jsr:@polymorph/test's package root IS the js/ subtree (browser-driver.mjs and viewer/ are siblings), so consumers resolving the package from JSR or its npm-compat registry got a mount rooted a directory too high and page imports that 404'd. The mount now roots at the module's own directory and serves /viewer/* — correct in both the package and this repo's checkout — and the page import map carries the @polymorph/test/* names next to the retired @polymorph/component-test-js/* ones (same values). Version 0.1.1 across the manifests (Cargo workspace, npm facade, js/deno.json): the JS-only fix ships as a caret-compatible patch release; the Rust side is unchanged. Gates: check, verify-imports (both selftests), verify-viewer, verify-deltic, deno publish --dry-run — all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First consumer of @polymorph/test (webcrypto's deltic-browser leg, mid-migration) found the harness server assuming the retired npm-facade layout:
PACKAGE_ROOTtwo dirnames up +/js/viewer/*mounts. The JSR package roots at thejs/subtree, so pages 404'd onpage-runner.mjs.browser-driver.mjs's own directory, serves/viewer/*— correct in the package and in this repo's checkout.@polymorph/test/*keys alongside the retired@polymorph/component-test-js/*ones (same values).Gates:
just check,verify-imports,verify-viewer,verify-deltic, publish dry-run — green.After merge: tag
v0.1.1+ release, dispatchjsr-publishfor @polymorph/test@0.1.1.