Converge .deps pins on the JSR-consuming siblings; gate module identity on the resolved graph - #46
Merged
Merged
Conversation
…ty on the resolved graph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up flagged in #45's review discussion: with the sibling JSR migrations merged (webrtc#153, webcrypto#364, websocket#46), the
.depspins move to those revisions and the deltic graph converges on ONE embedder.What this closes: before this bump, host-deltic's resolved graph carried TWO embedder copies — jsr
ga67ee83for the host + wasi-shims, and rawpre-58b2404pulled in by the webcrypto sibling (its package-shapeddeno.jsonmaps@deltic/runtime/embedderfor its own files; the entry import map never governed them). That's a liveinstanceof WitErroridentity split across the webcrypto boundary, latent on every error path — pre-dating #45, carried by the 48 raw-URL entries in host-deltic's lock that the review initially misread as cruft.What changed
scripts/setup.sh:WEBRTC_PIN→5dc3d41,WEBCRYPTO_PIN→a0c924d,WEBSOCKET_PIN→a3b7fb1(each repo's main, now consuming deltic from JSR at the same0.1.0-pre.ga67ee83this repo pins). TLS/IROH pins untouched (no deltic surface).scripts/deltic-identity-gate.ts, wired intoexam-deltic: the RESOLVED run-endpoint graph must carry exactly one@deltic/runtimeversion and zero raw-URL modules. Config greps cannot see this class (the split lived in a sibling's own config); only the graph can. Negative-tested: at the old pins it reports48 raw-URL modulesand fails; at the new pins it passes.Gates (all green):
just check;just build-components(endpoint recompiled against the bumped webcrypto/tls checkouts);just exam-deltic5/5 with both gates inline — scenario 1 exercises the converged webcrypto ed25519 path through the single embedder; relay-ws browser-test from fresh dist (phase-2 echo p50 590 µs); blobs browser-test (phase-2 fetch 6.39 MiB/s); ping-demobuild.sh;deno checkacross host-deltic, all three experiments, and the gate script.