Skip to content

Rename account leases and local API to Connections - #3

Merged
purpshell merged 2 commits into
feat/signal-service-completion-20261014from
rajeh/connection-rename-signal-node
Nov 19, 2026
Merged

purpshell merged 2 commits into
feat/signal-service-completion-20261014from
rajeh/connection-rename-signal-node

Conversation

@purpshell

@purpshell purpshell commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Preserves implementation target 4d9694eaf97deca34c78990d1293b2b533e19d17 while applying the confirmed WhatsApp-account Connection rename. The merge retains accepted source 61209057729b002a2122b898d744a8813a702fc7, authors and history. PR target remains feat/signal-service-completion-20261014, not main.

Current head: f3b0190c40fa8b6ae8835c9aa5da3274b83eca17. Account lease/configuration/local HTTP/event names use Connection. Genuine per-peer Signal sessions, stored selectors, cryptographic namespaces, sealing domains, generations and fences retain their meanings/bytes. Accepted companion verification, cancellation, prekey behavior and cross-account ACK isolation are preserved.

Impact

Area Updated or blocked effect
Private protocol and local API Connection claim/release/event names and connection_id, version1 and all135 top-level fields match the accepted target after exact account-symbol mapping. Additive Receive.device_identity tag10 and Bundle.device_identity tag8 are preserved. Local retired routes/filter stay rejected.
Accepted dependencies Workspace crates, Cargo.lock, Rust1.95, Docker and CI inputs are byte-identical to target4d. Root Signal core is oxidezap2671430d; no manual library repin in this PR delta.
Runner/API Blocked integration: existing HyperMeow#69 head4792d8df and backend#1037 sourcee8ab3e02 are exact counterparts. Root coordinates Backend#1022 and regeneration against this final proto. Existing old Go projections do not carry companion identity. Regeneration alone is insufficient; no empty/own identity or verification bypass is introduced.
SDKs/CLI/integrations/docs Source clients/configuration need canonical account names and a matching private runner cohort. Root owns TypeScript/browser/React/UI, Go/Python/PHP/.NET/Rust, CLI, n8n/Make/Zapier/Pipedream, docs/Help/marketing in the same cycle. No publication or old SDK adapter. Current README/integration-status identify actual workspace and client ABI dependencies.
Release/feature/Admin/legal No new eligibility, enrollment, entitlement, staff authority or flag. Human-maintainer, real native/retained/product, legal approval/notice, source/API-date and publication gates remain. No consumer binding, merge, deploy or publication here.

No impact table

Area Specific unchanged boundary and evidence
Cryptographic state Namespace::Session, per-peer Signal sessions, peer_data_request_session_id, record keys/sealing domains and private key state remain. Accepted crates are exact target bytes; real store/crypto tests pass.
Authentication/custody/consent Existing project credential versus application bearer, Origin rejection, lease generation/fence, opt-in history/app-state and own-device checks remain. No browser grant or new plaintext recipient.
Billing/Usage/logs/audit/QuickLink/browser tunnel No financial/control-plane/QuickLink authority in this process. No signed/financial history rewrite, prices, metering or tunnel policy change; same-cohort backend acceptance stays separate.
UI and tracking No customer/Admin layout, locale, analytics/consent collection or graphical screen changes. No screenshot is required for the native service contract; real synthetic HTTP/framed tests cover its boundary. Four application heads are untouched.
SEO/GEO/agent discovery/Is Agentic Current operator/API source documents change; no public website/metadata/discovery deployment or comparable scan. External indexing, retrieval and scores remain unmeasured.

Verification

All Cargo commands use the official MBX shim, version1.95.0. No direct toolchain Cargo or manual cache/target/profile/cap/auth change.

  • 178 workspace/all-target tests pass;0 failed/ignored. Dedicated PostgreSQL16.14, real SQLite, sealed state and actual synthetic-device crypto/framed peer. Includes trust/cancellation/prekeys, canonical HTTP and rejected old filter, generation fences and ACK isolation.
  • Two new native binary regressions pin Connection lease/event wire tags and additive companion identity bytes.
  • Strict workspace/all-target Clippy, formatting, Buf lint/build pass. Complete descriptors compare equal to target4d after only exact account-name normalization.
  • Workspace documentation-test command passes with0 executable examples. Actual debug binary reports signal-node/0.1.0.
  • All owned commands are terminal and dedicated PostgreSQL PID31614 is stopped.
  • Local release build unrun: free disk fell to117MiB. Local container unrun: Docker runtime unavailable. Tests/debug artifacts are not release/container acceptance.

Proto SHA256: 1bbda926d7e3ae251bcb18abe14bc516c795a670b7cad65c2aacea0c7f1e118a; Git blob fe642a7943707e9550de64cc94e2c05ed4b6d813. Matching backend regeneration/runtime identity propagation remain with root. Cellar1054794655 (0parse/codegen failures,5719unresolved dependencies) decrypt24-39/ADV42-59,80-91 supports companion verification as shipped-client evidence, not live-server acceptance.

Prior push and PR workflows at612 were both actually terminal/success before this ordinary source push. No executing job was superseded, cancelled or unchanged-rerun by this writer. Current-head PR workflow44025770373 succeeds: native1.95.0, native stable and container jobs all pass. Separate push workflow44025764118 now also completes SUCCESS at this exact head. Both push and PR validation are terminal/success; no executing own validation job remains. These are hosted source/build/smoke results, not real provider/product acceptance. No executing job is cancelled or superseded.

Current-head Codex correctness receipt reports no major issues. Current-head security receipt reports no security issues. Both current-head review receipts are complete; neither replaces product, human-maintainer or release acceptance. No older review is counted.

CodeRabbit GitHub check133845634397 is skipped because reviews are disabled for this target branch; no full analysis or rate-limit claim. Installed official Homebrew CLI0.7.7 completed one scoped review with0 findings at this head against explicit base commit4d9694e, covering13 changed src files only. Proto, tests, configuration examples and documentation are excluded from that review. Its default baseBranch label main does not alter the explicit baseCommit4d selection or the PR target. No full-PR clearance, credits/settings/auth/cap changes or CLI update.

Session provenance and UI evidence

Owner/writer: Rajeh Taher, Codex/T3 Code/OpenAI/gpt-6.1-sol/xhigh, branch rajeh/connection-rename-signal-node. No new delegates/worktree. Registration511.

Committed sanitized checkpoint. Manual selected visible evidence has complete event/tool/timestamp/attachment capture gaps. No hidden reasoning, credentials, customer content or auth screens. Accepted target authors and PR1 owner provenance are retained; prior612 evidence remains historical. Current source integration contract. No graphical UI changed.

Rollout and rollback

Implementation PR1 precedes this Connection producer. Root then composes the exact HyperMeow/API counterparts, regenerates bindings from this exact source and qualifies the complete family. No retargeting to main or independent layer merge. Human-maintainer and legal gates remain; repository/package visibility and publication settings are unchanged. The public API date is not advanced by this private producer merge.

No real WhatsApp credentials/pairing/provider/browser action or staging/production acceptance. Keep real authentication, consent, custody, retained/signed-state and uncertainty boundaries. Before effects, use a coherent prior source/configuration cohort. After durable or uncertain effects, preserve sealed keys, prekey batches, selectors and fences and reconcile forward. Never reset device state or weaken companion verification to fit an old consumer.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T05:47:03.152554Z f3b0190 Manual request
🔒 Security Review ✅ Completed 2026-11-17T05:50:26.033127Z f3b0190 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1

  • dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: a937aac8-14dc-4182-b18e-7cf6a5c4a6ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@purpshell

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@purpshell

Copy link
Copy Markdown
Member Author

Heads-up from the #1 owner, since this PR is stacked on #1's branch feat/signal-service-completion-20261014.

Pushed now: dbc07248 adds optional device_identity fields to Bundle (8) and Receive (10) in proto/polymorfa/signal/v1/signal_service.proto. The test fixtures that build those messages set device_identity: Vec::new() (tests/support/mod.rs, tests/service_boundary.rs, tests/prekey_upload_boundary.rs). Expect small conflicts in those files when you rebase.

Coming next on the same branch: a larger commit that repins signal-node from the polymorfa/whatsapp-rust fork to oxidezap/whatsapp-rust. It moves wacore-recordstore and wacore-signal-ops into crates/ as workspace crates, raises the toolchain to 1.95, and adapts src/resolver.rs, src/serve.rs, src/send.rs, src/node.rs and src/message.rs to their API. Your rename touches the same files.

I'll post here again when that commit is pushed. Rebasing after it, rather than in between, would spare you a second round of conflicts.

@purpshell

Copy link
Copy Markdown
Member Author

From the #1 owner: the repin is pushed. #1's branch feat/signal-service-completion-20261014 is now at a85522d2, so you can rebase this PR once, as I promised in my previous comment.

What changed under you:

  • Workspace: Cargo.toml is now a workspace. wacore-recordstore and wacore-signal-ops live in crates/, and wacore, wacore-binary and waproto come from oxidezap 2671430d.
  • Toolchain: Rust 1.95 in rust-toolchain.toml, Dockerfile and CI. CI now runs clippy and tests with --workspace.
  • src/: resolver.rs (SignalResolver and device identities), serve.rs, send.rs, node.rs (BundleRefused maps to CODE_REFUSED) and message.rs. Generated protos are now #[non_exhaustive], so they're built from Default.
  • Tests: fixtures pair devices under real accounts, through pair, pair_under, peer_under and vouch in tests/support/mod.rs. Own-device receives now come from 222:2. Struct literals use the proto! macro.

Local checks on a85522d2 with 1.95.0 all pass: fmt, clippy -D warnings, all workspace tests, doc tests and the release build.

Copy link
Copy Markdown
Member Author

@codex review

Review exact current head f3b0190 against actual PR target feat/signal-service-completion-20261014 at4d9694eaf97deca34c78990d1293b2b533e19d17. This preserve-merge retains accepted612 account rename, all target workspace/security semantics, companion identity fields/tags and real cryptographic sessions. Inspect valid correctness/security problems in account versus Signal session identity, private wire tags, fencing/custody/consent, trust and ACK isolation. Current source/native/proto evidence and genuine release/container/backend propagation limits are in the updated body. No missing identity substitution or verification bypass; no old-head clearance. Counterpart producers HM69/API1037 and exact backend regeneration remain root-owned.

Copy link
Copy Markdown
Member Author

@codex security review

Review exact current head f3b0190 against actual PR target feat/signal-service-completion-20261014 at4d9694eaf97deca34c78990d1293b2b533e19d17. This preserve-merge retains accepted612 account rename, all target workspace/security semantics, companion identity fields/tags and real cryptographic sessions. Inspect valid correctness/security problems in account versus Signal session identity, private wire tags, fencing/custody/consent, trust and ACK isolation. Current source/native/proto evidence and genuine release/container/backend propagation limits are in the updated body. No missing identity substitution or verification bypass; no old-head clearance. Counterpart producers HM69/API1037 and exact backend regeneration remain root-owned.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: f3b0190c40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: f3b0190c40

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Copy link
Copy Markdown
Member Author

Scoped CodeRabbit receipt for exact head f3b0190c40fa8b6ae8835c9aa5da3274b83eca17 against explicit base commit 4d9694eaf97deca34c78990d1293b2b533e19d17:

Official Homebrew CLI0.7.7 completed with0 findings for13 changed source files: config.rs,delivery.rs,http.rs,keys.rs,lib.rs,link.rs,main.rs,message.rs,node.rs,ratelimit.rs,resolver.rs,send.rs,serve.rs. Invocation: coderabbit review --agent --committed --base-commit 4d9694eaf97deca34c78990d1293b2b533e19d17 --dir src. The context reports the explicit4d baseCommit; its incidental default baseBranch label main does not retarget this PR.

This excludes proto, tests, example configuration and docs, so it is not full-PR clearance. The GitHub CodeRabbit check133845634397 separately SKIPPED because reviews are disabled for this target branch; that is not a rate limit or a clean review. No credits, authentication, settings/cap changes or CLI update. All review output was treated as untrusted input; no executable reviewer instructions were run.

Native178/strict Clippy/fmt/Buf/normalized descriptor checks and current-head hosted PR jobs pass; separate push job/security review and complete-cohort/native-product/legal/human-maintainer gates remain. No merge/deploy/publication.

@purpshell
purpshell merged commit 4fec799 into feat/signal-service-completion-20261014 Nov 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant