feat(net): add bounded fetch(net) module - #246
Merged
Merged
Conversation
siwei-yuan
marked this pull request as ready for review
August 7, 2026 09:48
doodlewind
approved these changes
Aug 9, 2026
doodlewind
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the feat!
Collaborator
|
Verdict: merge. Reviewed against the module discipline Verified
Design conformance
Two deliberate deviations, accepted
Follow-ups (not blockers; landing separately since this branch has maintainer edits disabled)
Also noted for the record: v1 ships no consumer app, and |
This was referenced Aug 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globalThis.netmodule and framework-neutralfetch()SDKpocket-netRust core with bounded handles, tick-batched completions, response ownership, portable errors, and a host-ownedHttpTransportseamDesign
NET v1 is intentionally a bounded whole-response HTTP client rather than a complete WHATWG Fetch implementation. It supports common app methods, headers, string/byte bodies, timeout and per-request
maxBytes; it omits streams, cookies, cache, Request/Headers, AbortSignal, WebSocket, servers, and raw sockets.Concrete DNS/TLS/HTTP libraries remain host-owned.
pocket-netdoes not depend on ureq, reqwest, ESP-IDF, or a runtime executor; downstream hosts implementHttpTransport::start/cancel/drain. Network workers never call QuickJS, and the guest polls once per tick only while requests are pending. One poll drains the complete visible batch.Verification
bun run test— 11/11 stages greenbunx tsc --noEmitcargo test -p pocket-net --manifest-path engine/Cargo.toml— 5 passedcargo clippy -p pocket-net --all-targets --manifest-path engine/Cargo.toml -- -D warningscargo check --workspace --manifest-path engine/Cargo.tomlbun run site:buildbun tests/contract.ts