Document why baseUrl is omitted in tsconfig.json#44
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PR Validation ✅All checks passed! Ready for review. Checks Performed:✓ Linting This is a complete dry-run of the deployment process, ensuring your changes will deploy successfully when merged. |
Code ReviewOverviewThis PR adds a 3-line comment to What's Good
One Concern — Version NumberThe comment says "TypeScript 5.5+", but Suggested alternatives: // baseUrl is intentionally omitted: TypeScript 5.0+ permits `paths` without
// `baseUrl` under `moduleResolution: "bundler"` (set by astro/tsconfigs/strict).
// Path values resolve relative to this tsconfig.json.Or, if the intent is specifically to warn TS 4.x users: // baseUrl is intentionally omitted. Under moduleResolution: "bundler"
// (TypeScript 5.0+, set by astro/tsconfigs/strict), `paths` entries resolve
// relative to this file without requiring baseUrl. TS 4.x projects need baseUrl.Everything Else
VerdictApprove with the minor version-number nit — worth a quick fix before merge so the comment doesn't mislead readers on TS 5.0–5.4. |
Drop the TypeScript 5.5+ version floor — the project pins TS 6, so the specific threshold is irrelevant here, and it was off by a couple of minor versions anyway. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PR Validation ✅All checks passed! Ready for review. Checks Performed:✓ Linting This is a complete dry-run of the deployment process, ensuring your changes will deploy successfully when merged. |
Code Review — PR #44: Document why
|
Summary
baseUrlis intentionally omitted: TypeScript 5.5+ permitspathswithoutbaseUrlundermoduleResolution: "bundler"(inherited fromastro/tsconfigs/strict), and path values resolve relative to the tsconfig itself.Addresses PR feedback requesting documentation of why the
baseUrlremoval is safe, to avoid confusing readers who may copy this config into a TS 4.x project.Test plan
just buildsucceeds