Skip to content

Align @types/node with Node 24 engines constraint#43

Merged
plx merged 1 commit intomainfrom
plx/types-node-24
Apr 28, 2026
Merged

Align @types/node with Node 24 engines constraint#43
plx merged 1 commit intomainfrom
plx/types-node-24

Conversation

@plx
Copy link
Copy Markdown
Owner

@plx plx commented Apr 24, 2026

Summary

  • Bumps @types/node from ^22.19.17 to ^24.12.2 so devDependencies match the engines: node >=24.0.0 constraint set in Bump to eslint 10 + typescript 6 #41.
  • Addresses PR feedback: eliminates the types/runtime mismatch so any future use of Node 24-specific APIs in build scripts gets correctly typed.

Test plan

  • npm install succeeds
  • just validate passes (lint, spellcheck, build, HTML spellcheck, link validation)

🤖 Generated with Claude Code

Bumps @types/node from ^22.19.17 to ^24.12.2 to match the
engines: node >=24.0.0 constraint, avoiding type/runtime drift
if build scripts start using Node 24-specific APIs.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

Code Review

Overview

This PR aligns @types/node with the engines: node >=24.0.0 runtime constraint established in #41. The change is small, well-scoped, and logically motivated.


Analysis

package.json

  • Single-line change: ^22.19.17^24.12.2. Correct and expected.

package-lock.json

  • The top-level @types/node entry is updated from 22.19.17 to 24.12.2, and its undici-types peer is bumped from ~6.21.0~7.16.0 accordingly.
  • The previously nested node_modules/sitemap/node_modules/@types/node@24.12.2 and its undici-types are removed — this is a clean deduplication win: sitemap was already pulling @types/node@24.x as a nested dep, so hoisting the top-level version to match eliminates the duplicate subtree.
  • The engines: { node: ">=24.0.0" } block now appears in the root package entry of the lockfile. This reflects the engines field added to package.json in Bump to eslint 10 + typescript 6 #41 being properly captured by this npm install run — minor, but correct.

Potential Issues / Risks

  • None identified. @types/node is a devDependency used only for TypeScript type-checking at build time; it has no runtime impact on the deployed static site.
  • The version jump (22 → 24) skips the Node 23 type definitions entirely, which is intentional given the >=24.0.0 engines pin.
  • undici-types upgrading from 6.x → 7.x is a major bump within this transitive dep, but since this is purely types (no runtime code), the practical risk is near-zero. If any project code directly imports from undici-types, TypeScript would surface any breaking type changes at compile time — covered by the just validate check in the test plan.

Test Plan Coverage

The test plan (npm install + just validate) is appropriate for this change. No additional tests are needed for a devDependency type bump.


Summary

Clean, correct, and well-motivated. The deduplication side-effect is a bonus. No changes requested. ✅

@github-actions
Copy link
Copy Markdown
Contributor

PR Validation ✅

All checks passed! Ready for review.

Checks Performed:

✓ Linting
✓ Spell check (source)
✓ Type checking & Build
✓ Spell check (HTML)
✓ Internal link validation
✓ Artifact upload

This is a complete dry-run of the deployment process, ensuring your changes will deploy successfully when merged.

@plx plx merged commit ec49eb7 into main Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant