Change config UI#8
Open
Lainow wants to merge 5 commits into
Open
Conversation
Rom1-B
approved these changes
Jun 5, 2026
stonebuzz
requested changes
Jun 5, 2026
| $migration->displayMessage("Installing $table"); | ||
| $query = "CREATE TABLE IF NOT EXISTS `$table` ( | ||
| `id` int unsigned NOT NULL AUTO_INCREMENT, | ||
| `is_active` tinyint NOT NULL DEFAULT '1', |
There was a problem hiding this comment.
You should drop this column if table already exist
Contributor
There was a problem hiding this comment.
The plugin hasn't been released yet
| `mandatory_task_group` tinyint NOT NULL DEFAULT '0', | ||
| PRIMARY KEY (`id`), | ||
| KEY `entities_id` (`entities_id`), | ||
| KEY `is_active` (`is_active`) |
There was a problem hiding this comment.
You should drop this column if table already exist
Comment on lines
+185
to
+196
| foreach (self::getItilConfigFields() as $field) { | ||
| $inheritance_labels[$field] = self::getInheritedValueBadge($parentConfig->fields[$field] ?? 0); | ||
| } | ||
| foreach ([ | ||
| 'take_requester_group_ticket', | ||
| 'take_requester_group_change', | ||
| 'take_requester_group_problem', | ||
| 'take_technician_group_ticket', | ||
| 'take_technician_group_change', | ||
| 'take_technician_group_problem', | ||
| ] as $field) { | ||
| $inheritance_labels[$field] = self::getInheritedValueBadgeForActorGroup($parentConfig->fields[$field] ?? 0); |
There was a problem hiding this comment.
self::getItilConfigFields already contain
'take_requester_group_ticket',
'take_requester_group_change',
'take_requester_group_problem',
'take_technician_group_ticket',
'take_technician_group_change',
'take_technician_group_problem',
The first loop at line
185 therefore generates a Yes/No badge for them (wrong — they need group-name labels), and the second explicit loop at line 188 immediately
overwrites with the correct badge.
There was a problem hiding this comment.
The test suite doesn't cover the grandparent → parent → child chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Change to the configuration interface (switch from checkboxes to “Yes”/‘No’ options with the “Inheritance” option)
Screenshots (if appropriate):