feat(DataSource\Lca\Boavistappi\Config): change URL override method#279
Merged
Merged
Conversation
use a regular constant instead of en environment variable, forced and fixed URL is now settable in downstream.php cleanup related dead code on Config class
btry
force-pushed
the
env_var_setting_with_downstream
branch
from
e10d040 to
bc2d4c5
Compare
btry
force-pushed
the
env_var_setting_with_downstream
branch
from
9795799 to
5462644
Compare
new CI feature added recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use a regular constant instead of en environment variable, forced and fixed URL is now settable in downstream.php cleanup related dead code on Config class