Revert unrelated getRowId selection/scroll parsing change after client-issue investigation#457
Revert unrelated getRowId selection/scroll parsing change after client-issue investigation#457
getRowId selection/scroll parsing change after client-issue investigation#457Conversation
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/7ee0283e-b2ea-42ea-ada6-1945cb19542e Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
getRowId parsing for bracket-notation keys in selection and scroll flows
|
Investigate again, I'm not sure that this was this issue, using the |
I re-investigated this in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Investigate the issue that the client was running into. |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/83b1bbd8-00ae-4f65-9048-0c375ab3f081 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Investigated the client issue path (the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
getRowId parsing for bracket-notation keys in selection and scroll flowsgetRowId selection/scroll parsing change after client-issue investigation
Follow-up investigation confirmed the client-reported issue was not caused by this PR’s
getRowIdselection/scroll logic.Scope correction
dataTypeDefinitionsfix on the stacked base branch (v35), not with thegetRowIdchange introduced here.getRowIdparsing/evaluation changes in internal selection and scroll flows.Code changes in this PR
getRowIdevaluator introduced for:selectedRowsreconciliationscrollTo.datahandlingTest updates
tests/test_selected_rows.pybecause it covered behavior that is no longer part of this PR.Validation performed
npm run buildnpm run lintpytest --headless tests/test_selected_rows.py -k "sr3"pytest --headless tests/test_cell_data_type_override.py -k "cd001"> [!WARNING]
>
>