feat: Allow for request headers to be passed in#446
Open
camdecoster wants to merge 5 commits intomasterfrom
Open
feat: Allow for request headers to be passed in#446camdecoster wants to merge 5 commits intomasterfrom
camdecoster wants to merge 5 commits intomasterfrom
Conversation
emilykl
reviewed
Apr 23, 2026
| # requires a couple extra lines | ||
| self.js_logger.reset() | ||
|
|
||
| await self._apply_headers() |
Collaborator
There was a problem hiding this comment.
Is there a potential for a race condition here, where some requests might get sent before the headers are applied? Should _apply_headers() be called earlier in this function?
Contributor
Author
There was a problem hiding this comment.
As we discussed, maybe? Moving this call earlier shouldn't hurt anything, so I'll do that.
emilykl
reviewed
Apr 23, 2026
| """Apply extra HTTP headers to the tab if configured.""" | ||
| if self._headers: | ||
| _logger.debug2(f"Setting extra HTTP headers on {self.tab}") | ||
| _raise_error(await self.tab.send_command("Network.enable")) |
Collaborator
There was a problem hiding this comment.
What is this "Network.enable" needed for?
Contributor
Author
There was a problem hiding this comment.
That needs to be called first so that the call to Network.setExtraHTTPHeaders will succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow for request headers to be passed from Kaleido to Choreographer.
Closes #445.
Changes
headerskeyword argument for Kaleido classTesting