Repository navigation
Conversation
With maxFiles reached the Browse row is hidden. A keyboard user who just chose a file there lost the focus to the page; it now moves on to the Upload button.
- A content item swallowed every key, Tab included, so the focus could not leave the list. It now only answers the keys it handles. - Each column is one tab stop, its current or first item, instead of a positive tabindex per item. - The upload and home buttons fired on any keydown, Tab included. They act on activation only. - Opening the upload form moves the focus to its Browse button. - Escape closes the browser from anywhere inside it, and the closed browser hands the focus back to the button that opened it.
MrTango
marked this pull request as ready for review
November 13, 2026 08:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the content browser usable from the keyboard and retain focus during uploads.
Evidence
After: Only navigation keys are intercepted; native button activation and explicit focus handoffs are covered by regression tests.
pnpm test --runInBand: 60 suites passed; 518 tests passed, 15 skipped.pnpm build:webpack: passed with size/performance warnings.Merge Danger
Door: two-way
Blast Radius: keyboard
Changes content-browser navigation and upload focus management.
Assisted-by: GPT 6.1 Sol