Revert new API and restore DBConnection - #412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
master.Why
The replacement HTTP pool and breaking public API are not ready to ship yet. Restoring the released DBConnection architecture lets
chpublish an Ecto 3.14-compatible release without forcing unrelated API, Elixir, and OTP migrations on users. Development of the new API can continue on a separate branch.The revert was resolved against current history rather than resetting or rewriting
master.Verification
v0.8.3; the DBConnection-era core files match that release, while the remaining diff consists only of intentionally retained maintenance, dependency, RowBinary, and test changes.Helptest-helper references remain.MIX_ENV=test mix format --check-formattedMIX_ENV=test mix compile --warnings-as-errorsMIX_ENV=test mix test— 605 passed, 10 skipped, 5 excludedmix deps.unlock --check-unusedgit diff --check