Handle late ClickHouse HTTP exceptions - #403
Open
ruslandoga wants to merge 8 commits into
Open
Conversation
ruslandoga
changed the title
ruslandoga
force-pushed
the
rd/clickhouse-http-errors
branch
from
August 9, 2026 15:11
fe719c2 to
87d7cd0
Compare
Collaborator
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects ClickHouse exceptions that are appended after a
200 OKresponse has begun, including the deliberate connection close used to signal an incomplete HTTP response. For the defaultRowBinaryWithNamesAndTypesformat, the accumulated response and exception tag are passed to the RowBinary decoder, which validates the trailer against that tag, its recorded message length, and ClickHouse's 16 KiB bound before returningCh.Error; unmatched truncation remains a Mint transport error. The restored DBConnection path discards the closed connection without retrying the failed query, while non-RowBinary formats retain their existing behavior. Adds a tagged real-ClickHouse regression test and excludes it on the older CI server version.