Skip to content

Support for ICC managed deployment #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcopiraccini merged 1 commit into from
Jul 2, 2026
Merged

Support for ICC managed deployment #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions chart/templates/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,21 @@ rules:
- services
verbs:
- delete
{{- if .Values.services.icc.features.skew_protection.manage_mode }}
# Skew protection manage mode (opt-in): ICC creates versioned Deployments and
# Services. Only granted when features.skew_protection.manage_mode is true;
# observe/advise modes never need it (advise applies via the external actor).
- apiGroups:
- ""
- apps
resources:
- deployments
- services
verbs:
- create
- update
- patch
{{- end }}
# Gateway API - for skew protection (opt-in)
- apiGroups:
- gateway.networking.k8s.io
Expand Down
1 change: 1 addition & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ services:
enable: false
skew_protection:
enable: false
manage_mode: false # Grant ICC create/update/patch on Deployments+Services (manage-mode deploys). Off = least privilege
auto_cleanup: false # Delete expired Deployment and Service resources
http_grace_period_ms: 1800000 # Min time to keep HTTP version draining (30 min)
http_max_alive_ms: 86400000 # Hard deadline for HTTP versions (24h)
Expand Down
Loading