Support for ICC managed deployment#89
Merged
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
marked this pull request as ready for review
July 1, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--via-iccdeploy path sodeskdrives deploys through ICC's deploy API letting you exercise the skew-protection actuation modes.Changes
desk deploy --via-icc --app-id <id> --deploy-token <plt_deploy_...> --image <ref> --version <v>:manage→ ICC creates the Deployment + Serviceadvise→ ICC returns manifests; desk applies them (--dry-runto only print)observe→ ICC rejects (default direct path, without--via-icc, is unchanged)lib/icc.js:deployViaIcc(Bearer deploy-token auth) + apply-the-plan helper.profiles/skew-protection.yaml: setsmanage_mode: trueso manage works out ofthe box — this needs the RBAC from Support for ICC managed deployment helm#61.
--via-icc.Backward compatible: default
desk deploybehavior is unchanged. Refs PRD-1862.