Repository navigation
fix: ship the utf-8 windows clipboard read; helper 0.2.1; plugin 0.9.2 - #78
Merged
Merged
Conversation
The clipboard fix from #74 changed only rust/src/clipboard.rs. The plugin installs the prebuilt helper pinned by herdr-annotate.version, which stayed at 0.2.0, and rust-lite-v0.2.0 was built before #74. Every install of main still ran the old `Get-Clipboard -Raw` read, whose output arrives in the ANSI or OEM code page. On a zh-CN machine (code page 936) that is GBK, and from_utf8_lossy turns each CJK character into U+FFFD. Bumping the helper to 0.2.1 lets a rust-lite-v0.2.1 release carry the fix. The new pin also makes existing installs fetch the new binary, because the fetchers skip a download only when the stamp matches. refs #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76. #74 fixed the Windows clipboard read in
rust/src/clipboard.rs, but installs download the pinned helper, andrust-lite-v0.2.0was built before #74. Users kept the old read and lost CJK text.This bumps the helper to 0.2.1 so a
rust-lite-v0.2.1release carries the fix, and bumps the plugin to 0.9.2 in all four manifests. The new pin makes existing installs fetch the new binary. The 0.9.2 plugin also includes #77.The
rust-lite-v0.2.1tag goes on this PR's head and the release must publish before this merges.