Repository navigation
fix(score): max_score follows the in-use scoring function on every shape - #21
Merged
Merged
Conversation
tin.max_score reports the highest score the relation's scoring function would produce, whatever the query's shape: the tin.score policy beside tin.score, and the tin.full_score policy otherwise. Under the tin.score policy it returned NULL for several indexes or a disjunction with other quals. Drop that branch so the summed maximum pass runs for every shape. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012mKGtrg7DEhVPgqYrJtHGg
eeeebbbbrrrr
approved these changes
Oct 6, 2026
eeeebbbbrrrr
added this pull request to stack #20
October 6, 2026 20:17
eeeebbbbrrrr
marked this pull request as ready for review
October 6, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #19.
Before: beside
tin.score,tin.max_scorereturned NULL on multi-index scans (title ==> 'zebra' OR body ==> 'zebra') and mixed ORs (body ==> 'zebra' OR id = 1).After: it returns the highest summed score of the in-use scoring function on every shape. This follows Eric's contract:
The fix deletes the NULL branch so the existing summed maximum pass runs. Tests compare
max_scorewithmax(score)over the same rows forscore,full_score, and no scoring function, including split-arm shapes.This intentionally diverges from current tin until TIN is fixed.