Skip to content

Warn when routing rules may not describe live routing - #1446

Open
cursor[bot] wants to merge 1 commit into
mainfrom
inc-881-routing-rules-get-warnings
Open

cursor[bot] wants to merge 1 commit into
mainfrom
inc-881-routing-rules-get-warnings

Conversation

@cursor

@cursor cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Surfaces warnings from GET .../routing-rules when a vtctld schema mutation is in progress.

  • Human output prints each warning to stderr as Warning: ....
  • JSON output preserves the API warnings array.

Tested: go test ./internal/cmd/branch/ ./internal/planetscale/, plus a local pscale branch routing-rules get against an API with a simulated mutation (stderr warning and JSON warnings both shown).

Open in Web View Automation 

Co-authored-by: max <max@planetscale.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots of pscale branch routing-rules get against an API with a simulated in-progress vtctld schema mutation.

Human output (warning on stderr, rules still returned):

CLI human output

JSON output (warnings array with code schema_mutation_in_progress):

CLI JSON output

View PR

Open in Web View Automation 

Sent by Cursor Automation: bugfix(vitess): author pull requests

@maxenglander
maxenglander marked this pull request as ready for review September 25, 2026 21:19
@maxenglander
maxenglander requested a review from a team as a code owner September 25, 2026 21:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant