Navigation/Breadcrumbs in filerunner, pull Nav into a component - #92

Open

bdsqqq wants to merge 78 commits into

mainfrom

igor/navigation-in-filerunner

Commits on Mar 6, 2023

add breadcrumbs and open file button to filerunner
bdsqqq
committed
5204871
remove px to align with content in filebrowser
bdsqqq
committed
cc0c32f
extract Nav/breadcrumbs into a component, we can name this better later
bdsqqq
committed
a5f32a6

Commits on Mar 7, 2023

expose `actions` from breadcrumbs (buttons in the right)
bdsqqq
committed
2bcacb1
use breadcrumbs component (still need to refactor filebrowser's menu bit)
bdsqqq
committed
dd8f73a
experimenting with Split button in filerunner
bdsqqq
committed
e52655c
added a TODO, need to validate this with mark or theo
bdsqqq
committed
2168258
a React.ReactNode shouldn't be inside a template literal
bdsqqq
committed
9146f84
solves TS warnings, there's probably a better way to do it
bdsqqq
committed
9814c7f
put form & submit button in a div to prevent unwanted dividers
bdsqqq
committed
b46f872
allow splitButton as actionItem
bdsqqq
committed
c8452d1
use Nav actions to render `open file` split button
bdsqqq
committed
e761d68
run hook button in Nav actions
bdsqqq
committed
bd1b353

Commits on Mar 8, 2023

add missing prop
bdsqqq
committed
a6ec460
unused import sorry
bdsqqq
committed
7a63679
add button from ping + used it in an implementation of splitButton
bdsqqq
committed
fc81751
replace ping button styles with styles from captain
bdsqqq
committed
2f0062b

Commits on Mar 9, 2023

Commits on Mar 10, 2023

Igor/nav in filerunner (#97)

bdsqqq
and
markflorkowski
authored
409122f
Igor/scared of fucking up main (#98)

authored
973008d

Commits on Mar 12, 2023

buttons inside dropdowns look weird with shadows, made shadows the default but optional
bdsqqq
committed
9f2c2fc
changing this in 2 places was kind of annoying, pulled it to a component
bdsqqq
committed
3d8f832
uhhhh, that component exploded everything for some reason, copy pasting once sounds better than debugging that
bdsqqq
committed
c01368a
w -> min-w to prevent children overflowing weirdly
bdsqqq
committed
2addfd9
removing this span makes the button height not break for some reason??
bdsqqq
committed
f27f6e5
consume icons correctly, a bit of styling
bdsqqq
committed
c5f9302
breadcrumb button types extend actual Button types
bdsqqq
committed
ebbcf6b
filebrowser provide icon to breadcrumbs actions correctly
bdsqqq
committed
daa885c
remove unused draft of spltbutton
bdsqqq
committed
5b550d6
rename SplitButtonDropdown to something not silly
bdsqqq
committed
4c5977b
update prop type to include icons
bdsqqq
committed
43306b2
fix mismatched icon types
bdsqqq
committed
06b8c3d
add Igor todo
bdsqqq
committed
50cfa93
add disabled styles to primary button
bdsqqq
committed
7b547e5
horizontally align filerruner to filebrwoser content
bdsqqq
committed
086fdb5
adding this span back, no consequences since were consuming icons properly in breadcrumbs now
bdsqqq
committed
af4c00d
base size for icon buttons being h-4 prevents annoying shift caused by breadcrumbs with icons being taller than ones without icons
bdsqqq
committed
03d9a0d
take hover style from three dots menu in App
bdsqqq
committed
c7b2645
remove arbitrary stuff I was too tired to make nice, actually made it nice
bdsqqq
committed
e0a837f
add slight bg change on button hover
bdsqqq
committed
78334f4
hover/focus tweaks
markflorkowski
committed
e4b5c28
Merge branch 'igor/navigation-in-filerunner' of https://github.com/pingdotgg/captain into igor/navigation-in-filerunner
markflorkowski
committed
e0de972
fixed-height buttons, remove dividers on file browser
markflorkowski
committed
7f6d3e6
remove unused imports
markflorkowski
committed
53faba4

Commits on Mar 13, 2023

add wells to file browser
markflorkowski
committed
4b1a976
fix mismatched icon types
bdsqqq
committed
9177f5e
start <App /> NavMenu migration to ButtonDropdown Component
bdsqqq
committed
c323bf2
support ButtonLinks in dropdowns
bdsqqq
committed
5fd8c9c
types and back compat for Links vs Buttons in dropdowns
bdsqqq
committed
dd93cfa
explicitelly use links on the App NavMenu dropdown
bdsqqq
committed
22e1d46
"finish" <App /> NavMenu migration to ButtonDropdown Component
bdsqqq
committed
12b185c
prevent clipping of actions with long names
bdsqqq
committed
f25817c

Commits on Mar 23, 2023

Commits on Mar 28, 2023

some fixes
markflorkowski
committed
ad7fc82
more fixes
markflorkowski
committed
bfa0416
commetns
markflorkowski
committed
75cfbeb
more fixes
markflorkowski
committed
3d04b51
openFile
markflorkowski
committed
30a8843
update warning message
markflorkowski
committed
a03ae02

Commits on Apr 20, 2023

Commits on Apr 22, 2023

add indigo button variant color
bdsqqq
committed
6cfb92a
button was missing `disabled` prop
bdsqqq
committed
ea55111
indigo disabled classes -> aria-disabled
bdsqqq
committed
a3a0d79
`Save Changes` button uses an actual <Button />
bdsqqq
committed
1e2f247
add cursor-not-allowed when button is disabled
bdsqqq
committed
edf09d2
file-form-modal button -> <Button />
bdsqqq
committed
4847b96
filebrowser buttons -> <Button />
bdsqqq
committed
99dd830
folder-form-modal buttons -> <Button />
bdsqqq
committed
3a93d35
white button doesn't turn gray on hover, add transition to buttons
bdsqqq
committed
003a488

Commits on May 13, 2023

center empty state vertically; max-w and center text
bdsqqq
committed
1f88cd4
fix: only center empty states, otherwise breaks hooks list
bdsqqq
committed
b4e77a3