fix(web): animate command palette when closing - #5169
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a16b5efe18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ApprovabilityVerdict: Needs human review Unresolved review comments identify substantive issues: stale palette state persisting after close, and a UI flash during exit animation. These bugs should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
|
cursor review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60eef677a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
cursor review |
|
@macroscope-app review |
|
Sorry, I'm unable to act on this request because you do not have permissions within this repository. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 60eef67. Configure here.
What Changed
Keep the command palette dialog mounted while Base UI runs its closing transition.
Why
The dialog returned
nullas soon as its open state changed to false, which skipped Base UI's ending transition and made the palette disappear immediately.UI Changes
Before:
before-fix.mp4
After:
after-fix.mp4
Checklist
Model: GPT-5
Harness: Codex
Note
Low Risk
Localized command-palette UI state and mount behavior with no auth, data, or API changes; regression risk is limited to palette open/close and mode shortcuts.
Overview
Fixes the command palette disappearing instantly on close by keeping
CommandPaletteDialogmounted instead of returningnullwhen closed. Visibility is left to the parentCommandDialog(open={state.open}), so Base UI can run its closing transition onCommandDialogPopup.The UI reducer
reduceCommandPaletteUiStateis adjusted to match that lifecycle: closing viaSetOpen(false)or toggling off the active mode no longer forcesmodeback tocommand; the current mode (files/content) is preserved while closed. Reopening withSetOpen(true)still opens in command mode and clearsopenIntenton close as before.Reviewed by Cursor Bugbot for commit fd2bb32. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Animate command palette when closing by keeping dialog subtree mounted
CommandPaletteDialogcomponent no longer unmounts when the palette closes; the outerCommandDialogcontrols visibility so the subtree stays mounted and can animate out.reduceCommandPaletteUiStatereducer now preserves the current mode on close instead of resetting to'command'; mode resets to'command'only when reopening viaSetOpen(true).ToggleModeon the active mode now closes the palette without resetting the mode.Macroscope summarized fd2bb32.