test(mobile): seed snoozed showcase threads - #5155
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 490b149 Test-only changes to mobile showcase seeding scripts. Adds seed data for snoozed threads and corresponding test assertions with no production runtime impact. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 490b149
What Changed
snoozed_untilandsnoozed_atin the generated showcase projection dataWhy
The mobile screenshot harness generates realistic thread data, but it did not include snoozed threads. That left the Snoozed shelf absent from generated screenshots and from disposable mobile test fixtures based on the showcase seeder.
UI Changes
No production UI code changed. Generated thread-list captures now include a collapsed
Snoozed (2)shelf backed by two expandable rows with different wake times.Verification
pnpm exec vp test run scripts/mobile-showcase.test.ts(19 tests)pnpm exec vp run --filter @t3tools/scripts typecheckpnpm exec vp lint --report-unused-disable-directives scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.tspnpm exec vp fmt --check scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.tsgit diff --checkChecklist
Model: GPT-5.6 Sol | Harness: Codex in T3 Code
Note
Low Risk
Changes only mobile showcase seeding and tests; no production UI or runtime behavior.
Overview
Extends the mobile screenshot/showcase seeder so generated thread lists include a Snoozed shelf, not only active, blocked, and settled rows.
Fixture data gains optional
snoozeMinuteson showcase threads.insertThreadmaps that tosnoozed_untilandsnoozed_atonprojection_threads. Two completed threads are snoozed with different wake times (hydration-haikusat 90 minutes,patient-penguinsat 8 hours), andpatient-penguinsis added as a ninth fixture thread.hasSeedableSchemanow requires those snooze columns before seeding runs.mobile-showcase.test.tsasserts nine threads, two snoozed entries with distinct durations, and that snoozed rows are completed (not working, blocked, or settled) while the primary deep-linked thread stays unsnoozed.Reviewed by Cursor Bugbot for commit 490b149. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Seed snoozed showcase threads in the mobile showcase environment
snoozeMinutesto theinsertThreadfunction in mobile-showcase-environment.ts, writingsnoozed_untilandsnoozed_atintoprojection_threadswhen provided (NULLs otherwise).hydration-haikus,patient-penguins) and adds a newpatient-penguinsentry, bringing the total from 8 to 9 showcase threads.hasSeedableSchemanow checks for the presence ofsnoozed_untilandsnoozed_atcolumns inprojection_threadsbefore allowing seeding.Macroscope summarized 490b149.