feat(web): add favorite thread markers - #5153
Draft
HabsaTheDog wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HabsaTheDog
force-pushed
the
agent/favorite-thread-markers
branch
from
August 1, 2026 13:00
1dd131a to
df14845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
There was no lightweight way to visually mark an important thread for later. This keeps the feature local to existing UI state and avoids server, database, or protocol changes.
Fix
The initial marker was nested inside the timestamp/status element, which intentionally fades out on row hover and focus. A context-menu interaction leaves the row in that state, so the favorite toggled correctly while its star remained hidden. The marker is now a sibling immediately before that transient slot in Sidebar V1, Sidebar V2 cards, and Sidebar V2 slim rows.
User impact
Right-clicking a thread now toggles a persistent favorite marker that stays visible, including immediately after the context-menu action. The marker survives app restarts and uses the existing amber palette in light and dark themes.
Validation
vp run --filter @t3tools/web typecheckvp test run apps/web/src/uiStateStore.test.ts(16 tests passed)Generated with Codex (GPT-5.6) in T3 Code via the Codex harness.