Skip to content

feat(web): add favorite thread markers - #5153

Draft
HabsaTheDog wants to merge 2 commits into
pingdotgg:mainfrom
HabsaTheDog:agent/favorite-thread-markers
Draft

feat(web): add favorite thread markers#5153
HabsaTheDog wants to merge 2 commits into
pingdotgg:mainfrom
HabsaTheDog:agent/favorite-thread-markers

Conversation

@HabsaTheDog

@HabsaTheDog HabsaTheDog commented Jul 31, 2026

Copy link
Copy Markdown

What changed

  • Add an Add to favorites / Remove from favorites action to thread context menus in both sidebar versions.
  • Persist favorites locally by scoped thread key, including sanitization during hydration.
  • Show a filled amber star immediately before the existing timestamp or status slot.
  • Keep the marker visible while the row's timestamp/status yields to hover and focus actions.

Why

There was no lightweight way to visually mark an important thread for later. This keeps the feature local to existing UI state and avoids server, database, or protocol changes.

Fix

The initial marker was nested inside the timestamp/status element, which intentionally fades out on row hover and focus. A context-menu interaction leaves the row in that state, so the favorite toggled correctly while its star remained hidden. The marker is now a sibling immediately before that transient slot in Sidebar V1, Sidebar V2 cards, and Sidebar V2 slim rows.

User impact

Right-clicking a thread now toggles a persistent favorite marker that stays visible, including immediately after the context-menu action. The marker survives app restarts and uses the existing amber palette in light and dark themes.

Validation

  • Targeted formatting and lint for both sidebar components
  • vp run --filter @t3tools/web typecheck
  • vp test run apps/web/src/uiStateStore.test.ts (16 tests passed)
  • Original web unit suite validation (201 files, 1,766 tests passed)

Generated with Codex (GPT-5.6) in T3 Code via the Codex harness.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fae7734d-9018-44c2-9f2d-f711afa8dace

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 31, 2026
@HabsaTheDog
HabsaTheDog force-pushed the agent/favorite-thread-markers branch from 1dd131a to df14845 Compare August 1, 2026 13:00
@HabsaTheDog HabsaTheDog changed the title Add favorite thread markers feat(web): add favorite thread markers Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant