Skip to content

fix(server): skip Codex page context in imported titles #31090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flexi767 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): skip Codex page context in imported titles #31090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion apps/server/src/project/AgentSessionScanner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2382,11 +2382,16 @@ describe("parseAgentSessionTranscript", () => {
]);
});

it("titles a Codex event after the request that follows injected setup blocks", () => {
it.each([
['<external_codex_apps_open_page>{"page_id":null}</external_codex_apps_open_page>'],
['<external_codex_apps_open_page>{"page_id":"page-1"}</external_codex_apps_open_page>'],
[""],
])("titles a Codex event after the request that follows injected setup blocks: %s", (page) => {
const prompt = [
"<recommended_plugins>\nGitHub\n</recommended_plugins>",
"# AGENTS.md instructions for /tmp/project\n\n<INSTRUCTIONS>\nRules\n</INSTRUCTIONS>",
'<in-app-browser-context source="ambient-ui-state">\nTab\n</in-app-browser-context>',
page,
"Fix the import titles",
].join("\n");
const thread = AgentSessionScanner.parseAgentSessionTranscript({
Expand All @@ -2407,6 +2412,43 @@ describe("parseAgentSessionTranscript", () => {
expect(thread?.messages.map((message) => message.text)).toEqual([prompt]);
});

it.each([
{
prompts: [
'<external_codex_apps_open_page>{"page_id":null}</external_codex_apps_open_page>',
"Import my sessions",
],
title: "Import my sessions",
},
{
prompts: ["Explain <external_codex_apps_open_page> in this transcript"],
title: "Explain <external_codex_apps_open_page> in this transcript",
},
{
prompts: ["<external_codex_apps_open_page>Keep this incomplete example"],
title: "<external_codex_apps_open_page>Keep this incomplete example",
},
])("derives a Codex title without discarding user text: $title", ({ prompts, title }) => {
const thread = AgentSessionScanner.parseAgentSessionTranscript({
contents: [
encodeTranscriptRecord({ type: "session_meta", payload: { id: "codex-session" } }),
...prompts.map((message) =>
encodeTranscriptRecord({
type: "event_msg",
payload: { type: "user_message", message },
}),
),
].join("\n"),
source: "codex",
providerInstanceId: ProviderInstanceId.make("codex"),
fallbackSessionId: "fallback",
lastActiveAtMs: Date.parse("2026-08-25T08:00:00.000Z"),
});

expect(thread?.title).toBe(title);
expect(thread?.messages.map((message) => message.text)).toEqual(prompts);
});

it("skips sessions without a visible user message", () => {
const thread = AgentSessionScanner.parseAgentSessionTranscript({
contents: JSON.stringify({
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/project/AgentSessionScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ function foldClaudeFields(fields: ClaudeFields, record: DecodedTranscriptRecord)
// Codex records setup context as user text ahead of the real request. Skip
// these leading blocks when deriving a title; imported messages keep them.
const CODEX_TITLE_PREAMBLE =
/^(?:\s*(?:<(recommended_plugins|environment_context|user_instructions|INSTRUCTIONS|in-app-browser-context)(?:\s[^>]*)?>[\s\S]*?<\/\1>|# AGENTS\.md instructions\b[^\n]*|## My request for Codex:))+/;
/^(?:\s*(?:<(recommended_plugins|environment_context|user_instructions|INSTRUCTIONS|in-app-browser-context|external_codex_apps_open_page)(?:\s[^>]*)?>[\s\S]*?<\/\1>|# AGENTS\.md instructions\b[^\n]*|## My request for Codex:))+/;

// Codex appends an entry per rename; like Codex, the newest nonempty name wins.
function parseCodexThreadNames(contents: string): ReadonlyMap<string, string> {
Expand Down
Loading