Repository navigation
fix(web): steered turns read like a chat with one fold at the end - #29589
Merged
maria-rcks merged 2 commits intoNov 2, 2026
Conversation
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Steered conversations now show preceding replies as chat and consolidate work into one fold after the latest steer, while removing steer timestamps. This changes the default conversation presentation and requires human confirmation of that product choice. You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
November 2, 2026 21:24
Dismissing prior approval to re-evaluate 45d6568
maria-rcks
merged commit Nov 2, 2026
931342c
into
pingdotgg:maria/redesign/2-composer-timeline
67 of 70 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 2 (#28840).
Replaces the per-segment fold rows from #29040, which is merged into layer 2. Supersedes #29076.
Problem
Steering a turn breaks it into segments, and each one gets its own "Continued for …" fold with its own diff totals. A turn with two steers shows three folds. The agent's replies between steers get folded away too. So you can't read the back-and-forth, and every steer label shows a time offset that doesn't help anyone.
Fix
A steered turn now reads like a chat: user, agent, user, agent, with one fold at the end.
Before / after
Validation
MessagesTimeline.logic.test.ts: I rewrote the per-segment steer cases for the new rule. They cover back-to-back steers stacking, replies between steers staying visible with no fold, one fold whose diff totals come from the turn's checkpoint, like the changed-files card, a stopped ending on that one fold, opened work listed under the fold, and a live turn with no folds and replies kept above the bar. The new cases fail on layer 2.MessagesTimeline.browser.test.tsxpasses.vp run check:changed origin/maria/redesign/2-composer-timelinepasses after merging layer 2 (with fix(web): steered turns' fold rows each show their own time and edits #29040) into this branch.MessagesTimelineand checked the settled, opened and live layouts.Made with Claude Opus 5.5 in Claude Code (via T3 Code).