[flamboh]

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 2 (#28840).

A design proposal. Right before the redesign branched, main's inline chips (skills, files, mentions, images, pasted text and the rest) dropped their pill: they are colored text with an icon that sits on the sentence's baseline at the sentence's size. The redesign puts every chip back in a small grey pill with a muted icon, so a message full of references reads as a row of buttons. This PR shows main's chips wearing the redesign's palette.

What changes

• Shape from main. No fill, border, fixed height or padding. The label inherits the sentence's size (the redesign shrank it to 0.86em) and sits on its baseline. Icon gap, focus ring, underline on hover for clickable chips and the 1em remove/comment action match main. The .context-chip pill rule and --context-reference-fill are gone.

• Colors from the redesign. Each kind's ink is a redesign token instead of main's per-theme solved accents:

  Kind	Token
  image, file, mention, thread, citation, Word doc	--info-foreground
  terminal, open PR, environment, spreadsheet	--success-foreground
  video, element, preview annotation, slides	--warning-foreground
  skill, review comment, PR, merged PR, epub	--merged-foreground
  closed PR, PDF, invalid	--error-foreground
  draft PR	--muted-foreground
  unresolved, neutral	the surrounding text color

  Most of these follow layer 1's first mapping. Environment moves from info to success because main's environment accent was green.

• Icons. File and mention chips show the file-type icon again, like the assistant's file links already do on this layer, instead of @. The redesign's citation glyph stays.

• Skill icon. Skill chips use main's package icon again instead of sparkles, in the composer, sent messages, assistant text, the "Used skill" timeline row's chip and the skill menu. The "Used skill" row's own icon on the left is the package too, so a skill has one icon everywhere.

• The voice-note bubble shape from feat(web): pasted text, voice notes, snapshots and sending files get their own shapes #27377 uses surface-bubble, like the redesign's file cards.

Clicks, removal, keyboard focus, tooltips, popovers and dir handling are unchanged. The chip test is back to main's version, which checks the label sits on the sentence baseline at the sentence size without growing the line.

Before / after

Every chip kind, in a composer area and in a sent message, rendered from the real components. Each grid shows main (fa31b66bbb, the stack's base), redesign layer 6, and this PR.

"Used skill" timeline row icon, dark:

Before	After

Made with Claude Opus 5.5 in Claude Code.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — Context chips become colored inline text with refreshed file and skill icons across composer and timeline views. The changes are presentation-focused, with file metadata access retaining existing permission and path safeguards.

Needs human approval because:

• Macroscope's correctness review did not reach a verdict

Notes:

• The correctness review was unavailable. Eligibility was assessed without its result.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 2571cc2

Dismissing prior approval to re-evaluate 3090161

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 3090161fc5ce6f1898582bfea8c608c3c7bbb98c on this linux boat vm.

• installed and ran github/main (6f41364805) first in a separate worktree. main already has inline chips; this regression belongs to the redesign branch. also ran the exact redesign base, 48c284581c, and reproduced grey pills with 12.04px labels inside 14px text.
• ran the exact pr head using vp i and the real background dev server. created the project and thread through the web app, pointing at the real checkout. used playwright from the repository with /usr/bin/google-chrome, and real codex gpt-6.1-sol turns through the app. no mocks, replay provider, fixtures, or demo data.
• selected file and skill references through the composer menus, sent them, and received the package name and a clickable file link from codex. the pr renders transparent, borderless chips at the surrounding 14px size, with the redesign colors and file/package icons. checked light and dark themes and 390px web width.
• neighboring behavior passed: composer and assistant file links open the real file preview; skill details open; image attachments preview; image and file attachments can be removed. a standalone skill turn completed and its "used skill" row shows the package icon. the saved thread remained usable after a server restart.
• vp run check:changed refs/remotes/verification/base passed through blacksmith-check: format, lint, both knip passes, affected typechecks, 20 tests across 5 files, and 9 affected react compiler checks. this includes the existing chip baseline test. the worker initially lacked chromium; installed it there and reran successfully.

main reference, with the same app-created message:

redesign base before:

pr after:

Not verified

native ios/android and electron shells, macos/windows behavior, remote relay/tunnel connections, and providers other than codex were not exercised on this linux web pass. voice-note bubbles, document formats beyond the attached json file, and every other context-chip kind/state were not exercised end to end. citation behavior passed existing browser tests but was not driven in the live client. this pass makes no performance claim.