Skip to content

fix(web): home screen project rows show the project they open - #29085

Merged
maria-rcks merged 1 commit into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-home-project-icon
Nov 2, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-home-project-icon

Conversation

@flamboh

@flamboh flamboh commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 1 (#28839).

Problem

The home screen's project rows could show another checkout's icon. Each row opens one checkout (targetProject) and shows that checkout's path, but it drew the icon of the group's representative. The representative prefers the primary environment's checkout.

So when a project group has two checkouts, the icon and the path can come from different places. A common case: a dev server registers its own apps/server folder as a project. That project joins the pingdotgg/t3code group and becomes the representative. Every T3 Code row then shows its "SR" monogram instead of the repo's favicon. The command palette doesn't have this problem, because it draws targetProject's icon.

Fix

The row's ProjectFavicon now gets targetProject, the same project as the palette's picker uses. The icon, path, and click target now all point at the same checkout. The new tab launcher reuses these rows, so it's fixed too.

Before / after

Before (layer 1) After
Recent project row shows the yellow SR badge beside the repo root path Recent project row shows the T3 favicon beside the same repo root path

Command palette on layer 1 already showed the correct checkout icon:

Before: command palette project list shows the T3 favicon for pingdotgg/t3code

Validation

  • Reproduced locally: dev server with an empty DB, its auto-created apps/server project, then the repo root added as a second checkout in the same group. Before: the Recent row showed "SR" next to the root path. After: the T3 favicon.
  • vp run check:changed origin/maria/redesign/1-primitives-shell passes.

Made by Claude Opus 5.5 in Claude Code (T3 Code).

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d4a7af7

Macroscope's review found this PR approvable — Home-screen project rows now render the favicon of the project they open. This is a limited presentation correction; project selection and stored settings remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks

maria-rcks commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified exact head d4a7af77277174444030467c7cf34732d996cc37 with repo playwright and /usr/bin/google-chrome on linux. no source changes were needed.

  • installed and ran github/main (84537c4dd9) in a separate worktree first. its older home project picker reproduced the incorrect "sr" icon for the repo-root checkout.
  • also ran the pr parent (dada6cc0cf) to capture the exact redesigned row before the fix. the before/after pair uses the same app-created project data and viewport: "sr" becomes the t3 favicon beside ~/t3code.
  • added the real repo through the app. clicked the project row and submitted real codex gpt-6.1-sol turns on main and the pr. the pr turn ran pwd and git rev-parse --show-toplevel; both returned /home/user/t3code and the client displayed the completed response.
  • checked the command palette project picker, the plus-button new-thread launcher, and keyboard pin/unpin. the favicon stays correct.
  • vp run check:changed dada6cc0cfba6f2a4168273fc4a5a598168bbd30 passed through blacksmith-check: format, lint, knip, affected typechecks, and react compiler validation. all 30 reported pr checks were successful.

main's older picker:

main home picker reproduces the sr icon mismatch

matching redesign before:

pr parent shows sr beside the repo root path

after:

pr head shows the t3 favicon beside the same repo root path

keyboard pin and unpin, palette, new-thread launcher, and real codex turn

Not verified

native desktop shells, ios/android, multi-environment connections, and other providers were not exercised on this linux web-client pass. mouse pinning did not pass: the row intercepted playwright's click on the pin control, including after hover. keyboard pin/unpin passed; the pin control code is unchanged by this pr.

@maria-rcks
maria-rcks merged commit 06895f6 into pingdotgg:maria/redesign/1-primitives-shell Nov 2, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants