Skip to content

fix(web): pull request header shows its repo and collapses on scroll again - #29058

Open
flamboh wants to merge 4 commits into
pingdotgg:maria/redesign/3-panels-pagesfrom
flamboh:t3/redesign-fix-pr-pane-header
Open

flamboh wants to merge 4 commits into
pingdotgg:maria/redesign/3-panels-pagesfrom
flamboh:t3/redesign-fix-pr-pane-header

Conversation

@flamboh

@flamboh flamboh commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 3 (#28841).

Problem

The redesigned pull request header lost two things main has. It no longer says which repository the pull request is from, which matters once a pull request pane sits next to threads from other projects. It also no longer collapses when you scroll, so the full title, author and branch rows always take about 145px.

Fix

  • The first row shows owner/repo before the number again, the same as main. It links to the repository when the host gives a URL. This row is the same expanded or collapsed, so the repo is always visible.
  • The collapse uses main's logic as-is. Scrolling Summary, Timeline or Code past the title block (its height plus 32px) folds the title and author rows into one compact row. Scrolling back to the top (under 4px) brings them back. Each tab keeps its own state, and the scroll position is adjusted so content doesn't jump.
  • The compact row uses the redesign's styling: avatar, title, and time. When the header is wide enough, it also shows base ← head. In narrow panes the title gets the space instead.
Before (layer 3) After
Top before: header without repository after: header with pingdotgg/t3code before #28841
Scrolled before: full header stays after scrolling after: collapsed header with repository, title and time

Wide header, collapsed, with branches:

after: wide collapsed header with branches

Validation

  • Headless captures against a dev server with a real pingdotgg/t3code pull request, dark mode. Header height goes 145px → 103px on Summary, 177px → 135px on Timeline (feat(web): add workspace panes and transitions #28845), and 181px → 139px on Code. It returns to full at the top, and switching tabs restores each tab's state.
  • vp run check:changed origin/maria/redesign/3-panels-pages passes.
  • Merges cleanly onto maria/redesign/6-workspace-panes.

Made with Claude Opus 5.5 in Claude Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The change restores repository identification and scroll-collapsing PR headers. It also adds a lint-suppression directive in PullRequestDetailPanel.tsx:424, which requires human review.

You can add or adjust custom eligibility rules. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant