Skip to content

fix(mobile): empty archive keeps the same top spacing as a filled one - #28857

Open
mapringg wants to merge 1 commit into
pingdotgg:mainfrom
mapringg:fix/mobile-archive-empty-spacing
Open

mapringg wants to merge 1 commit into
pingdotgg:mainfrom
mapringg:fix/mobile-archive-empty-spacing

Conversation

@mapringg

@mapringg mapringg commented Nov 1, 2026

Copy link
Copy Markdown

Problem

The empty archive card begins immediately under the header, while a filled archive starts with a project group that has additional top spacing. Empty and populated states therefore have inconsistent content spacing.

Change

Give the loaded empty state the same pt-4 wrapper used by the first project group. The loading state keeps its existing layout.

Scope and approval

Submitted as a small, focused fix of an obvious spacing inconsistency between two states of the same list, with no prior issue. It adds only the missing spacing around the empty state.

Verification

Android API 36 emulator in dark mode, showcase data only. Checked the fresh served bundle for pt-4 around EmptyState, then compared empty and filled archives. The before/after captures show the empty card moving down; the filled archive is included as a spacing reference. iOS was not run.

node_modules/.bin/vp run check:changed passed at this branch head in the previous session; Sol review approved the diff. No fix code changed during evidence collection.

Before — archive empty After
Before After

Populated archive reference (one archived showcase thread):

Populated archive

Code written by Claude Opus 5.5; evidence and PR filing by GPT-6.1 Sol, both in T3 Code.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 14fc104

Macroscope's review found this PR approvable — Adds top spacing to the mobile archive empty state to match a populated archive. This is a presentation-only adjustment with no changes to archive behavior or data.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1db31d0 and 14fc104.

Files selected for processing: 1
  • apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The archived-thread empty state is now wrapped in a view with top padding. Its filtered and unfiltered titles and details are unchanged.

Changes: Archived-thread empty state

Layer / File(s) Summary
Add top padding to the empty state
apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx
The empty state is wrapped in a view with top padding. Its filtered and unfiltered titles and details are unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: only21mil

Merge Risk: Minimal · up to 14fc1

The spacing adjustment is ready to merge with no actionable risk remaining.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the main change: the empty archive state now keeps the same top spacing as a filled archive. It uses a conventional commit prefix and a plain-language description that matches the raw …
Description check Passed The description follows the template sections: Problem, Change, Scope and approval, and Verification. It states the problem, the fix, and why no prior issue exists. It explains the focused fix and inc…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the empty archive state now keeps the same top spacing as a filled archive. It uses a conventional commit prefix and a plain-language description that matches the raw summary, which wraps the empty state in a pt-4 view.

Full details: Description check

Explanation

The description follows the template sections: Problem, Change, Scope and approval, and Verification. It states the problem, the fix, and why no prior issue exists. It explains the focused fix and includes before/after screenshots and a model attribution. The Verification section is thorough, but it relies on a previous-session check and does not show a current run. The Scope section gives a reason for no linked issue, which the template allows only for very small, focused fixes of an obvious bug. This is a reasonable match for a spacing fix, but a maintainer may still question the no-issue justification.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant