Skip to content

fix(mobile): thread status icons follow the theme in dark mode - #28856

Open
mapringg wants to merge 1 commit into
pingdotgg:mainfrom
mapringg:fix/mobile-status-icons-dark-mode
Open

mapringg wants to merge 1 commit into
pingdotgg:mainfrom
mapringg:fix/mobile-status-icons-dark-mode

Conversation

@mapringg

@mapringg mapringg commented Nov 1, 2026

Copy link
Copy Markdown

Problem

Floating thread-status icons use the invalid foreground tint class and fall back to black, making them nearly invisible against dark-mode surfaces. This affects command, settled, snoozed, compacting, and other status labels.

Change

Use the existing accent-foreground tint token at all six affected SymbolView call sites.

Scope and approval

Submitted as a small, focused fix of an obvious icon-visibility defect, with no prior issue. This corrects an invalid theme-token namespace without changing status behavior.

Verification

Android API 36 emulator in dark mode, seeded showcase data. Opened the settled “Tune the handoff haptics” thread: the checkmark changes from near-black to the foreground color. No real agent turn was started. Checked the fresh served bundle for the corrected tint. Other status variants share the corrected token but were not individually driven; iOS was not run.

node_modules/.bin/vp run check:changed passed at this branch head in the previous session; Sol review approved the diff. No fix code changed during evidence collection.

Before — status icons After
Before After

Code written by Claude Opus 5.5; evidence and PR filing by GPT-6.1 Sol, both in T3 Code.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ece4b38

Macroscope's review found this PR approvable — Updates six mobile thread-status icons to use the theme-aware tint convention already used elsewhere in the app. The change is presentation-only and leaves thread behavior and product defaults unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1db31d0 and ece4b38.

Files selected for processing: 1
  • apps/mobile/src/features/threads/floating-working-control.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

Six status icons in the mobile floating working control now use accent-foreground instead of foreground. No other behavior changed.

Changes: Status icon tint updates

Layer / File(s) Summary
Update status icon tints
apps/mobile/src/features/threads/floating-working-control.tsx
The compacting, child-input, lifecycle, background, goal, and preparing status icons now use accent-foreground.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested labels: bugfix, size:M

Suggested reviewers: maria-rcks, macroscopeapp

Merge Risk: Minimal · up to ece4b

This narrowly scoped visual change has no concrete merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the mobile thread status icon theme fix and uses a concise conventional-commit format.
Description check Passed The description includes all required sections. It explains the dark-mode visibility problem, identifies the six tint-token changes, justifies the focused scope, and records Android verification, scre…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes all required sections. It explains the dark-mode visibility problem, identifies the six tint-token changes, justifies the focused scope, and records Android verification, screenshots, bundle checks, test status, and known limitations.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant