Repository navigation
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Android archive now uses the standard screen header with expandable search, keeping filter menus accessible during search. The change is limited to presentation and local interaction; archive data operations and iOS inline search remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Set archived search mode by platform apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx |
Archived-thread search uses inline mode on iOS. Other platforms receive an undefined mode. |
Use the shared Android search path apps/mobile/src/components/ui/AppBar.android.tsx |
Android inline search uses the common header and search overlay. Hardware-back handling applies whenever search is active. The shared trailing content appears in the header and active search overlay. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 7f78b
-
No actionable issue is established with the Android archive header or search behavior; the PR appears mergeable after normal checks.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the behavior, implementation, scope rationale, test environment, observed checks, limitations, and UI evidence. The lack of prior maintainer approval is disclosed, with the change described as a focused fix.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Problem
The Android archive uses a separate inline search header, so its back/search/filter controls differ from other Settings screens. Opening the standard search overlay also hides trailing header menus.
Change
Use the standard Android archive header while retaining inline search on iOS. Keep trailing menus visible in the Android search overlay, so the archive filter remains available while searching. The same AppBar fix keeps the Files refresh menu and Settings root filter visible during search.
Scope and approval
Submitted as a small, focused fix of inconsistent archive header controls and the filter disappearing during search, with no prior issue. The header normalization is closer to a design change and has no prior maintainer approval; maintainers may decline that direction. Both commits keep the archive controls consistent and usable through search.
Verification
Android API 36 emulator, dark mode, showcase data only. Checked the fresh served bundle for the platform-specific inline mode. Verified the archive title/back/search/filter row, opened search, and opened its filter menu while searching. Additional baseline/search images from the prior session used fresh Metro. The shared Files/Settings search paths were inspected in code; iOS was not run.
node_modules/.bin/vp run check:changedpassed at this branch head in the previous session; Sol review approved the diff. No fix code changed during evidence collection.Filter menu open during search:
Code written by Claude Opus 5.5; evidence and PR filing by GPT-6.1 Sol, both in T3 Code.