Skip to content

fix(mobile): Android archive uses the standard screen header - #28855

Open
mapringg wants to merge 2 commits into
pingdotgg:mainfrom
mapringg:fix/mobile-android-archive-header
Open

mapringg wants to merge 2 commits into
pingdotgg:mainfrom
mapringg:fix/mobile-android-archive-header

Conversation

@mapringg

@mapringg mapringg commented Nov 1, 2026

Copy link
Copy Markdown

Problem

The Android archive uses a separate inline search header, so its back/search/filter controls differ from other Settings screens. Opening the standard search overlay also hides trailing header menus.

Change

Use the standard Android archive header while retaining inline search on iOS. Keep trailing menus visible in the Android search overlay, so the archive filter remains available while searching. The same AppBar fix keeps the Files refresh menu and Settings root filter visible during search.

Scope and approval

Submitted as a small, focused fix of inconsistent archive header controls and the filter disappearing during search, with no prior issue. The header normalization is closer to a design change and has no prior maintainer approval; maintainers may decline that direction. Both commits keep the archive controls consistent and usable through search.

Verification

Android API 36 emulator, dark mode, showcase data only. Checked the fresh served bundle for the platform-specific inline mode. Verified the archive title/back/search/filter row, opened search, and opened its filter menu while searching. Additional baseline/search images from the prior session used fresh Metro. The shared Files/Settings search paths were inspected in code; iOS was not run.

node_modules/.bin/vp run check:changed passed at this branch head in the previous session; Sol review approved the diff. No fix code changed during evidence collection.

Before — archive header After
Before After
Before — archive search After
Before After

Filter menu open during search:

Filter menu open

Code written by Claude Opus 5.5; evidence and PR filing by GPT-6.1 Sol, both in T3 Code.

mapringg and others added 2 commits November 2, 2026 00:33
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 7f78bdd

Macroscope's review found this PR approvable — Android archive now uses the standard screen header with expandable search, keeping filter menus accessible during search. The change is limited to presentation and local interaction; archive data operations and iOS inline search remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1db31d0 and 7f78bdd.

Files selected for processing: 2
  • apps/mobile/src/components/ui/AppBar.android.tsx
  • apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

Archived-thread search now selects inline mode only on iOS. On Android, inline search uses the shared header and search overlay, with hardware-back handling while search is active.

Changes: Android search header

Layer / File(s) Summary
Set archived search mode by platform
apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx
Archived-thread search uses inline mode on iOS. Other platforms receive an undefined mode.
Use the shared Android search path
apps/mobile/src/components/ui/AppBar.android.tsx
Android inline search uses the common header and search overlay. Hardware-back handling applies whenever search is active. The shared trailing content appears in the header and active search overlay.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 7f78b

No actionable issue is established with the Android archive header or search behavior; the PR appears mergeable after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main change: using the standard screen header for the Android archive. It is concise and specific.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the behavior, implementation, scope rationale, test environment, observed checks, limi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the behavior, implementation, scope rationale, test environment, observed checks, limitations, and UI evidence. The lack of prior maintainer approval is disclosed, with the change described as a focused fix.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant