[iXab3r]

Problem

Host-dependent fixtures cause 14 test failures on Windows and one on macOS: JSON path escaping, an inherited platform, and temporary-directory aliases.

Change

Check attachment paths directly in message text, use native installation behavior, and canonicalize the temporary directory. Pin the tool-search fixture's intended Linux platform.

Scope

Small test-only portability fixes: two existing files, +14/−8, no production changes.

Reported in #22552 (Windows) and #27001, #26967 (macOS). Related stability report #22324 describes separate failures outside this PR.

Verification

Node 26.12.1, Vite Plus 1.4.0, Vitest 5.0.5; identical dependencies for each BEFORE/AFTER pair.

vp test run apps/server/src/environment/ServerEnvironment.test.ts apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts

OS / evidence	BEFORE	AFTER
Windows 11, build 26200	14 failed, 273 passed, 1 skipped	287 passed, 1 skipped
macOS 26.6.2, arm64	1 failed, 287 passed	288 passed
Nobara Linux 44, x86_64	288 passed	288 passed

All OS pairs: 8760d063e903 → afdd55366741. Submitted commit 2172e6859992 has the identical Git tree, with the patch consolidated into one commit.

check:changed passed: static checks and 288 tests, one skipped.

Model and harness: GPT-6.1 Sol via Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 2172e68

Macroscope's review found this PR approvable — Changes are confined to ignored server test files and describe making host-dependent fixtures portable. The supplied scope presents no evident material impact on production behavior.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 8760d06
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 202556b5-acdc-4946-a022-8ff2ca4098db

Commits

Reviewing files that changed from the base of the PR and between 8760d06 and 2172e68.

Files selected for processing: 2

• apps/server/src/environment/ServerEnvironment.test.ts
• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The changes update two test areas: installation-ownership expectations now account for the host platform, and Claude attachment assertions inspect extracted message text.

Changes: Environment test portability

Layer / File(s)	Summary
Platform-aware installation ownership test apps/server/src/environment/ServerEnvironment.test.ts	The test resolves the temporary directory to its real path and uses the host platform. It expects npm-global installation only in web mode on non-Windows platforms.

Claude attachment test assertions

Layer / File(s)	Summary
Message-text attachment checks apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts	A helper extracts string content or joins text blocks. Attachment assertions check the extracted text, and the tool-search test provides the Linux platform service.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• pingdotgg/t3code#22773: Both PRs update the server installation descriptor and its installation-ownership test.

Suggested labels: size:XS

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 2172e

No actionable merge-blocking risk is established by the portability-only test changes.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: making server test fixtures portable across host platforms.
Description check		The description covers the problem, changes, scope, linked reports, focused verification command, cross-platform results, and tooling details. It uses a “Scope” heading instead of “Scope and approval”…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description covers the problem, changes, scope, linked reports, focused verification command, cross-platform results, and tooling details. It uses a “Scope” heading instead of “Scope and approval” and does not state explicit maintainer approval, but the required information is otherwise substantially complete.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts