Skip to content

fix(marketing): the download page offers the Windows arm64 installer - #28306

Open
only21mil wants to merge 2 commits into
pingdotgg:mainfrom
only21mil:fix/audit-m032
Open

only21mil wants to merge 2 commits into
pingdotgg:mainfrom
only21mil:fix/audit-m032

Conversation

@only21mil

@only21mil only21mil commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The download page's Windows section has a single x64 .exe card. Every release also publishes T3-Code-<version>-arm64.exe (v0.1.6 has it, and docs/operations/release.md lists the Windows arm64 installer), but nothing on the page links to it. Windows on ARM users (Snapdragon X laptops and similar) get the x64 build, which runs under emulation. macOS and Linux already show a one-line link to their other architecture.

Change

Add an "On ARM? Download the arm64 build." line under the Windows card, in the same intel-note style as the macOS and Linux lines. Its link has data-asset="arm64.exe", so the page's existing script resolves it to the release asset ending in -arm64.exe on both the Stable and Nightly channels. It falls back to the releases page like the other links. No script or style changes.

Scope and approval

There is no issue. This is a three-line markup fix that exposes an installer the release already ships, using the pattern the page already uses for macOS and Linux. The homepage download button is unchanged: it picks one default per OS and leaves other architectures to this page.

Prior PRs

#18508 by @mweinbach included this same line among several Windows on ARM changes. It was closed on 2026-10-12 with a request to split it into focused PRs, one problem each. The updater part continues in #18520, which doesn't touch the marketing site. This PR is the download-page part on its own.

Verification

  • vp run check:changed: format and typecheck (astro check, 0 errors) pass.
  • No test: this is markup only, so the captures below are the proof.
  • Built the marketing site from main and from this branch, served each locally, and captured /download in headless Chromium against the live public release data.

Before (main, Stable): the Windows section has only the x64 card.

Before: Windows shows only the x64 installer

After (Stable): an "On ARM?" line under the Windows card links to T3-Code-0.1.6-arm64.exe.

After: Windows on ARM link under the Windows card

After (Nightly): the same link resolves to the nightly's -arm64.exe.

After: nightly channel with the Windows on ARM link

After, at phone width.

After: phone width

Generated with Claude Opus 5.5 and GPT-6.1 Terra in T3 Code Nightly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 31, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d2462fa

Macroscope's review found this PR approvable — Adds an optional Windows ARM64 download link using the existing release-selection and fallback behavior. The primary Windows download and product defaults remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Windows download section now shows a localized Windows ARM note with a link to the arm64.exe release asset. The note and link label are available in nine locales.

Changes: Windows ARM download

Layer / File(s) Summary
Add Windows ARM link
apps/marketing/src/i18n/*.ts, apps/marketing/src/pages/[...locale]/download.astro
Nine locale files add text for the Windows ARM note and arm64 link. The download page renders the note with a link to the arm64.exe asset.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: t3dotgg, maria-rcks

Merge Risk: Minimal · up to 1868b

The localized Windows ARM link uses the expected release-asset naming. No merge-blocking issue was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding a Windows arm64 installer link to the marketing download page.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains why the focused change needs no prior issue, reports checks and manual verification, a…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains why the focused change needs no prior issue, reports checks and manual verification, and includes before-and-after screenshots.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d2462fa and 1868b45.

Files selected for processing: 10

  • apps/marketing/src/i18n/de.ts
  • apps/marketing/src/i18n/en.ts
  • apps/marketing/src/i18n/es.ts
  • apps/marketing/src/i18n/fr.ts
  • apps/marketing/src/i18n/ja.ts
  • apps/marketing/src/i18n/ko.ts
  • apps/marketing/src/i18n/pt-BR.ts
  • apps/marketing/src/i18n/ru.ts
  • apps/marketing/src/i18n/zh.ts
  • apps/marketing/src/pages/[...locale]/download.astro

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Localize the Windows arm64 note to match the localized download page.
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

Merged current main (merge commit, no rebase). main moved the download page to [...locale]/download.astro and localized every string, so the hardcoded English note would have shown in English on all locales. I moved it into windowsArmNote / windowsArmLink in each i18n/*.ts, matching the existing intelNote / intelLink pattern. Behavior is unchanged: the link still resolves to the -arm64.exe release asset (checked against v0.1.8: T3-Code-0.1.8-arm64.exe).

Checks: vp run check:changed and apps/marketing build pass.

Before (main):
download page Windows section on main, no arm64 note

After (en):
download page Windows section with "On ARM? Download the arm64 build." note

After (ja):
download page Windows section with Japanese arm64 note

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Nov 10, 2026
@only21mil

Copy link
Copy Markdown
Contributor Author

Note

🤖 Opus 5.5 replying on behalf of Victor.

Thank you for merging main and carrying the note over to the localized download page. Moving it into windowsArmNote / windowsArmLink in all nine i18n/*.ts files, using the same pattern as intelNote / intelLink, means non-English locales no longer get a hardcoded English string, and against main the PR is now just those keys plus the one download.astro link. Your check against the v0.1.8 arm64.exe asset shows the link resolves, and the en/ja captures show the note renders in both locales.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants