Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
953163e to
3f25fca
Compare
- Use coarse-pointer detection to switch Enter handling - Increase composer text size on mobile - Surface sidebar actions on touch devices
Port the mobile composer collapse feature from PR pingdotgg#1263 into the extracted ChatComposer component. On small viewports (<640px), the composer collapses to a compact single-row bar showing truncated prompt text and a send button when unfocused. Tapping expands the full composer with editor focus; blurring collapses it back. Also adds onPointerDown handlers on submit buttons to prevent iOS from stealing focus before the click registers. Co-authored-by: Hiram Chirino <hiram@hiramchirino.com>
3f25fca to
1ba7e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Mobile touch UX improvements to the chat composer and sidebar:
Enterinserts a newline;Cmd/Ctrl+Entersends. Desktop behavior (Enter sends, Shift+Enter newlines) is unchanged.text-baseon small screens to avoid iOS auto-zoom on focus, stepping down totext-[14px]atsmand above.preventDefaultonpointerDownto prevent stealing focus from the editor on touch devices.Why
On mobile/touch devices, the composer was hard to use: Enter would send instead of adding newlines (no physical Shift key), text was too small (triggering iOS auto-zoom), sidebar actions were hidden behind hover states that don't exist on touch, and the full composer took up too much vertical space on small screens.
UI Changes
Composer collapsed (mobile default):
Composer expanded (after tap):
Sidebar: