Skip to content

fix(web): allow text selection when renaming threads - #12935

Open
carterwsmith wants to merge 1 commit into
pingdotgg:mainfrom
carterwsmith:fix/thread-rename-text-selection
Open

carterwsmith wants to merge 1 commit into
pingdotgg:mainfrom
carterwsmith:fix/thread-rename-text-selection

Conversation

@carterwsmith

@carterwsmith carterwsmith commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What Changed

Disable sidebar card dragging while a thread is being renamed. Dragging is restored after saving or canceling. Applies to web and desktop.

Why

Dragging to select text in the rename field starts dragging the thread card instead. Disabling dragging during renaming lets the input handle text selection normally.

UI Changes

Before

before.mov

After

Screen.Recording.2026-09-21.at.11.15.37.AM.mov

Implemented with GPT-6 in Codex.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included a video for animation/interaction changes

Summary by CodeRabbit

  • Bug Fixes
    • Thread rows can no longer be dragged while they are being renamed, preventing accidental moves during editing.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b17c9afd-59e5-42f1-bd47-b22ba437912a

📥 Commits

Reviewing files that changed from the base of the PR and between 371b52d and 78279b5.

📒 Files selected for processing (1)
  • apps/web/src/components/Sidebar.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar now prevents thread dragging while a thread is being renamed. Existing dragging restrictions remain unchanged.

Changes

Thread dragging

Layer / File(s) Summary
Rename-aware dragging restriction
apps/web/src/components/Sidebar.tsx
Thread rows are non-draggable while the rename input is active. Existing capability and optimistic-drop restrictions remain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the change, the reason, the UI impact, and the implementation scope. It includes before-and-after media and completes the relevant checklist items.
Title check ✅ Passed The title clearly and concisely describes the primary fix: enabling text selection while renaming threads by preventing conflicting dragging behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 78279b5

Macroscope's review found this PR approvable — This is a small, self-contained sidebar interaction fix: dragging is disabled only while a thread title is being edited, allowing normal text selection without changing other thread behavior. It introduces no schema, deployment, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant