fix(web): allow text selection when renaming threads - #12935
carterwsmith wants to merge 1 commit into
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe sidebar now prevents thread dragging while a thread is being renamed. Existing dragging restrictions remain unchanged. ChangesThread dragging
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained sidebar interaction fix: dragging is disabled only while a thread title is being edited, allowing normal text selection without changing other thread behavior. It introduces no schema, deployment, security, billing, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
What Changed
Disable sidebar card dragging while a thread is being renamed. Dragging is restored after saving or canceling. Applies to web and desktop.
Why
Dragging to select text in the rename field starts dragging the thread card instead. Disabling dragging during renaming lets the input handle text selection normally.
UI Changes
Before
before.mov
After
Screen.Recording.2026-09-21.at.11.15.37.AM.mov
Implemented with GPT-6 in Codex.
Checklist
Summary by CodeRabbit